GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119180: Lazily wrap annotations on classmethod and staticmethod by JelleZijlstra · Pull Request #119864 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 31, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Implement PEP 649 and PEP 749 #119180

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-119180: Lazily wrap annotations on classmethod and staticmethod
f0d430f
@JelleZijlstra
JelleZijlstra requested review from ambv and carljm May 31, 2024 15:25
@bedevere-app bedevere-app Bot mentioned this pull request May 31, 2024
Implement PEP 649 and PEP 749 #119180
Closed
21 of 30 tasks
carljm
carljm approved these changes May 31, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label May 31, 2024
@JelleZijlstra
JelleZijlstra marked this pull request as ready for review May 31, 2024 21:04
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting merge labels May 31, 2024
@JelleZijlstra
JelleZijlstra merged commit d28afd3 into python:main May 31, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label May 31, 2024
@JelleZijlstra
JelleZijlstra deleted the pep649-staticclassm branch May 31, 2024 21:05
@AlexWaygood

AlexWaygood commented May 31, 2024

Copy link
Copy Markdown
Member

Hmm, what's the plan for functools.update_wrapper? Some kind of pure-Python version of this descriptor, that lazily queries the original __annotations__?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented May 31, 2024

Copy link
Copy Markdown
Member Author

If the wrapper is a Python function, we can just copy over __annotate__, and the __annotations__ descriptor will know to call the __annotate__. If the wrapper is not a Python function, I'm not sure yet.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented Jun 1, 2024

Copy link
Copy Markdown
Member Author

@AlexWaygood I implemented this in JelleZijlstra@672511a
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@JelleZijlstra @estyxx
pythongh-119180: Lazily wrap annotations on classmethod and staticmet…
b55b6a0 
…hod (python#119864)
@JelleZijlstra
JelleZijlstra restored the pep649-staticclassm branch September 10, 2024 23:37
@AA-Turner AA-Turner mentioned this pull request Oct 6, 2024
Segfault on cls.__dict__['__new__'].__annotations__ #125017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@JelleZijlstra @AlexWaygood @carljm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.