GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117657: Fix TSAN race in QSBR assertion by colesbury · Pull Request #119887 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented May 31, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Due to a limitation of TSAN, all reads from PyThreadState.state must be atomic to avoid reported races.

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-117657: Fix TSAN race in QSBR assertion
6191a8b 
Due to a limitation in TSAN, all reads from PyThreadState.state must be
atomic to avoid reported races.
@colesbury colesbury added skip news topic-free-threading needs backport to 3.13 only security fixes labels May 31, 2024
@colesbury
colesbury requested a review from DinoV May 31, 2024 20:54
@bedevere-app bedevere-app Bot added the awaiting core review label May 31, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 31, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
@colesbury
Adjust suppressions
1e113f2
Fidget-Spinner
Fidget-Spinner approved these changes Jun 1, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 1, 2024
@colesbury
colesbury merged commit 90ec19f into python:main Jun 1, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 1, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 1, 2024
@colesbury
colesbury deleted the gh-117657-qsbr branch June 1, 2024 14:04
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 1, 2024
@colesbury @miss-islington
pythongh-117657: Fix TSAN race in QSBR assertion (pythonGH-119887)
397f847 
Due to a limitation in TSAN, all reads from `PyThreadState.state` must be
atomic to avoid reported races.
(cherry picked from commit 90ec19f)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 1, 2024

Copy link
Copy Markdown

GH-119904 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 1, 2024
colesbury added a commit that referenced this pull request Jun 1, 2024
@miss-islington @colesbury
[3.13] gh-117657: Fix TSAN race in QSBR assertion (GH-119887) (#119904)
48054d2 
Due to a limitation in TSAN, all reads from `PyThreadState.state` must be
atomic to avoid reported races.
(cherry picked from commit 90ec19f)

Co-authored-by: Sam Gross <[email protected]>
@wiggin15

wiggin15 commented Jun 1, 2024

Copy link
Copy Markdown
Contributor

Don't we want to use the FT_ATOMIC_LOAD_* macro from pycore_pyatomic_ft_wrappers.h to avoid affecting the GIL code?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury

colesbury commented Jun 1, 2024

Copy link
Copy Markdown
Contributor Author

No:

  • it's in qsbr.c, which is only used in the free-threaded build.
  • it's in an assertion (so debug only)
  • using the FT_* macros in places where there's no performance reason to do so tends to make code harder to read without sufficient benefit
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@colesbury @barneygale
pythongh-117657: Fix TSAN race in QSBR assertion (python#119887)
d60317e 
Due to a limitation in TSAN, all reads from `PyThreadState.state` must be
atomic to avoid reported races.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@colesbury @estyxx
pythongh-117657: Fix TSAN race in QSBR assertion (python#119887)
e04e145 
Due to a limitation in TSAN, all reads from `PyThreadState.state` must be
atomic to avoid reported races.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@DinoV DinoV Awaiting requested review from DinoV

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@colesbury @wiggin15 @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.