GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117657: Avoid `sem_clockwait` in TSAN by colesbury · Pull Request #119915 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Jun 1, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The sem_clockwait function is not currently instrumented by TSan, which leads
to false positives.

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury colesbury added skip news topic-free-threading needs backport to 3.13 only security fixes labels Jun 1, 2024
@colesbury
colesbury requested a review from corona10 June 1, 2024 16:25
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 1, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 1, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
@colesbury
colesbury marked this pull request as draft June 1, 2024 16:34
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 1, 2024
@colesbury

colesbury commented Jun 1, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

EDIT: Needed to disable sem_clockwait. We do that in thread_pthread.h, but not in parking_lot.c.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
pythongh-117657: Avoid sem_clockwait in TSAN
11936b3 
The `sem_clockwait` function is not currently instrumented, which leads
to false positives.
@colesbury
colesbury force-pushed the gh-117657-parking-lot-suppressions branch from 96bb646 to 11936b3 Compare June 1, 2024 19:11
@colesbury colesbury changed the title gh-117657: Remove parking lot related TSAN suppressions gh-117657: Avoid sem_clockwait in TSAN Jun 1, 2024
@colesbury
colesbury marked this pull request as ready for review June 1, 2024 19:45
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 1, 2024
@colesbury
Merge branch 'main' into pythongh-117657-parking-lot-suppressions
2190744
@colesbury
colesbury requested a review from DinoV June 3, 2024 16:16
@colesbury
Merge branch 'main' into pythongh-117657-parking-lot-suppressions
94c30a9
DinoV
DinoV reviewed Jun 3, 2024
View reviewed changes

@DinoV DinoV left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
colesbury merged commit 41c1cef into python:main Jun 3, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 3, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury deleted the gh-117657-parking-lot-suppressions branch June 3, 2024 17:42
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 3, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2024
@colesbury @miss-islington
pythongh-117657: Avoid sem_clockwait in TSAN (pythonGH-119915)
737da25 
The `sem_clockwait` function is not currently instrumented, which leads
to false positives.
(cherry picked from commit 41c1cef)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 3, 2024

Copy link
Copy Markdown

GH-119992 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 3, 2024
colesbury added a commit that referenced this pull request Jun 3, 2024
@miss-islington @colesbury
[3.13] gh-117657: Avoid sem_clockwait in TSAN (GH-119915) (#119992)
ca37034 
The `sem_clockwait` function is not currently instrumented, which leads
to false positives.
(cherry picked from commit 41c1cef)

Co-authored-by: Sam Gross <[email protected]>
mliezun pushed a commit to mliezun/cpython that referenced this pull request Jun 3, 2024
@colesbury @mliezun
pythongh-117657: Avoid sem_clockwait in TSAN (python#119915)
93d38fc 
The `sem_clockwait` function is not currently instrumented, which leads
to false positives.
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@colesbury @barneygale
pythongh-117657: Avoid sem_clockwait in TSAN (python#119915)
a232d05 
The `sem_clockwait` function is not currently instrumented, which leads
to false positives.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@colesbury @estyxx
pythongh-117657: Avoid sem_clockwait in TSAN (python#119915)
ad9d50b 
The `sem_clockwait` function is not currently instrumented, which leads
to false positives.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DinoV DinoV DinoV left review comments
@corona10 corona10 Awaiting requested review from corona10

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@colesbury @DinoV
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.