GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117657: Fix TSAN reported race in `_PyEval_IsGILEnabled`. by colesbury · Pull Request #119921 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Jun 1, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The GIL may be disabled concurrently with this call so we need to use a relaxed atomic load.

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-117657: Fix TSAN reported race in _PyEval_IsGILEnabled.
317b01b 
The GIL may be disabled concurrently with this call so we need to use a
relaxed atomic load.
@colesbury colesbury added skip news topic-free-threading needs backport to 3.13 only security fixes labels Jun 1, 2024
@colesbury
colesbury requested review from DinoV and corona10 June 1, 2024 20:05
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 1, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 1, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
corona10
corona10 approved these changes Jun 2, 2024
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_PyEval_IsGILEnabled is called at free-threaded build only so using atomic operation directly looks reasonable.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 2, 2024
@colesbury
colesbury merged commit f3b89a6 into python:main Jun 2, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 2, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 2, 2024
@colesbury
colesbury deleted the gh-117657-is-gil-enabled branch June 2, 2024 14:19
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 2, 2024
@colesbury @miss-islington
pythongh-117657: Fix TSAN reported race in _PyEval_IsGILEnabled. (p…
7dc0140 
…ythonGH-119921)

The GIL may be disabled concurrently with this call so we need to use a
relaxed atomic load.
(cherry picked from commit f3b89a6)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 2, 2024

Copy link
Copy Markdown

GH-119939 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 2, 2024
colesbury added a commit that referenced this pull request Jun 2, 2024
@miss-islington @colesbury
[3.13] gh-117657: Fix TSAN reported race in _PyEval_IsGILEnabled. (G…
9d3de7b 
…H-119921) (#119939)

The GIL may be disabled concurrently with this call so we need to use a
relaxed atomic load.
(cherry picked from commit f3b89a6)

Co-authored-by: Sam Gross <[email protected]>
mliezun pushed a commit to mliezun/cpython that referenced this pull request Jun 3, 2024
@colesbury @mliezun
pythongh-117657: Fix TSAN reported race in _PyEval_IsGILEnabled. (p…
ad1c71a 
…ython#119921)

The GIL may be disabled concurrently with this call so we need to use a
relaxed atomic load.
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@colesbury @barneygale
pythongh-117657: Fix TSAN reported race in _PyEval_IsGILEnabled. (p…
e2633ae 
…ython#119921)

The GIL may be disabled concurrently with this call so we need to use a
relaxed atomic load.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@colesbury @estyxx
pythongh-117657: Fix TSAN reported race in _PyEval_IsGILEnabled. (p…
9b4168f 
…ython#119921)

The GIL may be disabled concurrently with this call so we need to use a
relaxed atomic load.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@DinoV DinoV Awaiting requested review from DinoV

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@colesbury @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.