GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118934: Fix PyEval_GetLocals docs (PEP 667) by ncoghlan · Pull Request #119932 · python/cpython

Conversation

@ncoghlan

@ncoghlan ncoghlan commented Jun 2, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PEP 667's description of the planned changes to PyEval_GetLocals was internally inconsistent when accepted, so the docs added for gh-74929 didn't match either the current behaviour or the intended behaviour once gh-118934 is fixed.

This PR updates the documentation and 3.13 What's New to match the intended behaviour (once gh-118934 is fixed).

📚 Documentation preview 📚: https://cpython-previews--119932.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ncoghlan
pythongh-118934: Fix PyEval_GetLocals docs (PEP 667)
4906559 
PEP 667's description of the planned changes to PyEval_GetLocals
was internally inconsistent when accepted, so the docs added for
pythongh-74929 didn't match either the current behaviour or the intended
behaviour once pythongh-118934 is fixed.

This PR updates the documentation and 3.13 What's New to match the
intended behaviour (once pythongh-118934 is fixed).
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting core review labels Jun 2, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 2, 2024
PyEval_GetLocals() leaks locals #118934
Closed
ncoghlan added 2 commits June 2, 2024 14:18
@ncoghlan
Add missing full stop
bb7b16f
@ncoghlan
Merge remote-tracking branch 'origin/main' into pythongh-118934-fix-p…
5a95f35 
…yeval_getlocals-docs
@ncoghlan ncoghlan self-assigned this Jun 2, 2024
@ncoghlan ncoghlan added 3.13 only security fixes 3.14 bugs and security fixes needs backport to 3.13 only security fixes labels Jun 2, 2024
@ncoghlan
Only new dict entries are preserved
97aac6f
@ncoghlan
ncoghlan enabled auto-merge (squash) June 2, 2024 04:33
@ncoghlan

ncoghlan commented Jun 2, 2024

Copy link
Copy Markdown
Contributor Author

Set to auto-merge, since I don't want to risk the currently incorrect docs making their way into beta2 this week.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ncoghlan
ncoghlan merged commit fd6cd62 into python:main Jun 2, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 2, 2024

Copy link
Copy Markdown

Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 2, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 2, 2024

Copy link
Copy Markdown

Sorry, @ncoghlan, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fd6cd621e0cce6ba2e737103d2a62b5ade90f41f 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ncoghlan ncoghlan added needs backport to 3.13 only security fixes and removed needs backport to 3.13 only security fixes labels Jun 2, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 2, 2024

Copy link
Copy Markdown

Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 2, 2024
@ncoghlan @miss-islington
pythongh-118934: Fix PyEval_GetLocals docs (PEP 667) (pythonGH-119932)
f8b96ac 
PEP 667's description of the planned changes to PyEval_GetLocals
was internally inconsistent when accepted, so the docs added for
pythongh-74929 didn't match either the current behaviour or the intended
behaviour once pythongh-118934 is fixed.

This PR updates the documentation and 3.13 What's New to match the
intended behaviour (once pythongh-118934 is fixed).

It also tidies up lingering references to `f_locals` always being a
dictionary (this hasn't been true since at least when custom
namespace support for class statement execution was added)
(cherry picked from commit fd6cd62)

Co-authored-by: Alyssa Coghlan <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 2, 2024

Copy link
Copy Markdown

GH-119934 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 2, 2024
@ncoghlan

ncoghlan commented Jun 2, 2024

Copy link
Copy Markdown
Contributor Author

Conflict was due to my failure to merge #119894 yesterday. Fixed that, and retriggered miss-islington
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ncoghlan ncoghlan mentioned this pull request Jun 2, 2024
gh-118934: Make PyEval_GetLocals return borrowed reference #119769
Merged
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@ncoghlan @barneygale
pythongh-118934: Fix PyEval_GetLocals docs (PEP 667) (python#119932)
bb2c6c5 
PEP 667's description of the planned changes to PyEval_GetLocals
was internally inconsistent when accepted, so the docs added for
pythongh-74929 didn't match either the current behaviour or the intended
behaviour once pythongh-118934 is fixed.

This PR updates the documentation and 3.13 What's New to match the
intended behaviour (once pythongh-118934 is fixed).

It also tidies up lingering references to `f_locals` always being a
dictionary (this hasn't been true since at least when custom
namespace support for class statement execution was added)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@ncoghlan @estyxx
pythongh-118934: Fix PyEval_GetLocals docs (PEP 667) (python#119932)
1029d72 
PEP 667's description of the planned changes to PyEval_GetLocals
was internally inconsistent when accepted, so the docs added for
pythongh-74929 didn't match either the current behaviour or the intended
behaviour once pythongh-118934 is fixed.

This PR updates the documentation and 3.13 What's New to match the
intended behaviour (once pythongh-118934 is fixed).

It also tidies up lingering references to `f_locals` always being a
dictionary (this hasn't been true since at least when custom
namespace support for class statement execution was added)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ncoghlan ncoghlan

Labels

3.13 only security fixes 3.14 bugs and security fixes docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ncoghlan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.