GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119396: Optimize unicode_decode_utf8_writer() by vstinner · Pull Request #119957 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 2, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Take the ascii_decode() fast-path even if dest is not aligned on size_t bytes.

  • Issue: Optimize _PyUnicodeWriter implementation #119396

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
Optimize unicode_decode_utf8_writer()
95a86bf
Take the ascii_decode() fast-path even if dest is not aligned on
size_t bytes.
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 2, 2024
@vstinner

vstinner commented Jun 2, 2024

Copy link
Copy Markdown
Member Author

Benchmark (C part, _testcapimodule.c):

static PyObject *
bench(PyObject *Py_UNUSED(module), PyObject *args)
{
    const char *str;
    Py_ssize_t loops;
    if (!PyArg_ParseTuple(args, "ny", &loops, &str)) {
        return NULL;
    }

    PyTime_t t1, t2;
    (void)PyTime_PerfCounterRaw(&t1);
    for (Py_ssize_t i=0; i < loops; i++) {
        PyObject *obj = PyUnicode_FromFormat("=%s", str);
        if (obj == NULL) {
            return NULL;
        }
        Py_DECREF(obj);
    }
    (void)PyTime_PerfCounterRaw(&t2);
    return PyFloat_FromDouble(PyTime_AsSecondsDouble(t2 - t1));
}

Benchmark (Python part):

import pyperf
import _testcapi
runner = pyperf.Runner()

arg = b'x' * 10
runner.bench_time_func("FromFormat('x'*10)", _testcapi.bench, arg)
arg = b'x' * 1_000
runner.bench_time_func("FromFormat('x'*1_000)", _testcapi.bench, arg)

Result:

+-----------------------+---------+-----------------------+
| Benchmark             | ref     | change                |
+=======================+=========+=======================+
| FromFormat('x'*10)    | 75.9 ns | 68.7 ns: 1.11x faster |
+-----------------------+---------+-----------------------+
| FromFormat('x'*1_000) | 200 ns  | 191 ns: 1.05x faster  |
+-----------------------+---------+-----------------------+

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner vstinner changed the title Optimize unicode_decode_utf8_writer() gh-119396: Optimize unicode_decode_utf8_writer() Jun 2, 2024
@vstinner vstinner added the skip news label Jun 2, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 2, 2024
Optimize _PyUnicodeWriter implementation #119396
Closed
@vstinner
vstinner merged commit 3ea9b92 into python:main Jun 3, 2024
@vstinner
vstinner deleted the ascii_decode branch June 3, 2024 06:45
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 3, 2024
mliezun pushed a commit to mliezun/cpython that referenced this pull request Jun 3, 2024
@vstinner @mliezun
pythongh-119396: Optimize unicode_decode_utf8_writer() (python#119957)
433ef5c
Optimize unicode_decode_utf8_writer()

Take the ascii_decode() fast-path even if dest is not aligned on
size_t bytes.
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@vstinner @barneygale
pythongh-119396: Optimize unicode_decode_utf8_writer() (python#119957)
dba3cb1
Optimize unicode_decode_utf8_writer()

Take the ascii_decode() fast-path even if dest is not aligned on
size_t bytes.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-119396: Optimize unicode_decode_utf8_writer() (python#119957)
adfb692
Optimize unicode_decode_utf8_writer()

Take the ascii_decode() fast-path even if dest is not aligned on
size_t bytes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.