GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (GH-119591) by miss-islington · Pull Request #119985 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 3, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 42a34dd)

Co-authored-by: Jason R. Coombs [email protected]

  • Issue: Implement zipfile.Path.is_symlink #119588

📚 Documentation preview 📚: https://cpython-previews--119985.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jaraco @miss-islington
pythongh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (py…
094c41e
…thonGH-119591)

(cherry picked from commit 42a34dd)

Co-authored-by: Jason R. Coombs <[email protected]>
@miss-islington
miss-islington requested a review from jaraco as a code owner June 3, 2024 15:13
@bedevere-app bedevere-app Bot mentioned this pull request Jun 3, 2024
gh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). #119591
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jun 3, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 3, 2024
Implement zipfile.Path.is_symlink #119588
Closed
@jaraco

jaraco commented Jun 3, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@Yhg1s Can you confirm you consider this issue to be a (security) bug and thus qualifies for merge here and in 3.12?

The bug/security concern is that if a user were to use zipfile.Path().is_symlink() to screen for symlinks thinking that it was actually checking, and then they were to unzip that file using another tool that honor symlinks, they could inadvertently be creating symlinks where they expected not to create them.

It feels slightly more like a feature than a bug fix to me, and I don't feel strongly about it. I'll follow whatever direction you or a delegate wish to go.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jaraco
jaraco requested a review from Yhg1s June 3, 2024 16:07
@Yhg1s

Yhg1s commented Jun 4, 2024

Copy link
Copy Markdown
Member

No, I do not believe these are important security fixes, and they're changes in behaviour that could just as easily cause security issues. The ZIP standard is much to fluid, what with all its extensions, that you can't mix and match implementations and expect a sensible result. Verifying contents with zipfile and then unpacking with a different tool altogether does not make sense from a security perspective. I believe we should simply consider this a bugfix with a change in semantics. However, I'm okay with this going into 3.13 at this stage, just not 3.12.

jaraco reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Yhg1s Yhg1s mentioned this pull request Jun 4, 2024
[3.12] gh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (GH-119591) #119988
Closed
Yhg1s
Yhg1s approved these changes Jun 4, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 4, 2024
@jaraco
jaraco merged commit 34a6d89 into python:3.13 Jun 4, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 4, 2024
@miss-islington
miss-islington deleted the backport-42a34dd-3.13 branch January 2, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s approved these changes
@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @jaraco @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.