GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). by jaraco · Pull Request #119591 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented May 27, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Implement zipfile.Path.is_symlink #119588

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaraco
pythongh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0).
48b69a0
@jaraco jaraco added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 27, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label May 27, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 27, 2024
Implement zipfile.Path.is_symlink #119588
Closed
@jaraco
Update docs to include is_symlink and capture when it was added and w…
a410099 
…hen it changed.
@jaraco
jaraco requested a review from Yhg1s May 27, 2024 01:53
@jaraco

jaraco commented May 27, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@Yhg1s - I've tagged you on the review as I'd like your opinion on whether this qualifies as a bugfix for Python 3.12. It's considered a security issue by some (that's how it was reported to me), but since the issue was introduced in 3.12, there's no need to backport it to security-only Pythons.

Are you okay with including this change as a bugfix for Python 3.12 (and by extension 3.13), or would you rather keep the "always false" behavior for 3.12 and 3.13?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco
jaraco merged commit 42a34dd into python:main Jun 3, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 3, 2024

Copy link
Copy Markdown

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 3, 2024
@jaraco
jaraco deleted the zipfile-is-symlink branch June 3, 2024 15:13
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2024
@jaraco @miss-islington
pythongh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (py…
094c41e 
…thonGH-119591)

(cherry picked from commit 42a34dd)

Co-authored-by: Jason R. Coombs <[email protected]>
@miss-islington-app

miss-islington-app Bot commented Jun 3, 2024

Copy link
Copy Markdown

Sorry, @jaraco, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 42a34ddb0b63e638905b01e17a7254623a0de427 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Jun 3, 2024

Copy link
Copy Markdown

GH-119985 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned jaraco Jun 3, 2024
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 3, 2024
@bedevere-app

bedevere-app Bot commented Jun 3, 2024

Copy link
Copy Markdown

GH-119988 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jun 3, 2024
mliezun pushed a commit to mliezun/cpython that referenced this pull request Jun 3, 2024
@jaraco @mliezun
pythongh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (py…
578b6ce 
…thon#119591)
jaraco added a commit that referenced this pull request Jun 4, 2024
@miss-islington @jaraco
[3.13] gh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (G…
34a6d89 
…H-119591) (#119985)

gh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (GH-119591)
(cherry picked from commit 42a34dd)

Co-authored-by: Jason R. Coombs <[email protected]>
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@jaraco @barneygale
pythongh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (py…
25d0a68 
…thon#119591)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@jaraco @estyxx
pythongh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (py…
dd2c3f3 
…thon#119591)
@MicroMilo MicroMilo mentioned this pull request Jul 1, 2026
zipfile.Path.is_symlink() raises KeyError for missing entries #152762
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jaraco jaraco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@jaraco
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.