GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-120026: deprecate (soft) Py_HUGE_VAL macro by skirpichev · Pull Request #120027 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented Jun 4, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Deprecate (soft) Py_HUGE_VAL macro #120026

📚 Documentation preview 📚: https://cpython-previews--120027.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting review label Jun 4, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 4, 2024
Deprecate (soft) Py_HUGE_VAL macro #120026
Closed
@skirpichev
pythongh-120026: deprecate (soft) Py_HUGE_VAL macro
5b7bc64
@skirpichev
skirpichev force-pushed the sd-Py_HUGE_VAL branch from d5ab44f to 5b7bc64 Compare June 4, 2024 10:43
@skirpichev

skirpichev commented Jun 4, 2024

Copy link
Copy Markdown
Member Author

As mentioned here I'm not sure that Py_NAN/INFINITY now are really required.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
skirpichev added 2 commits August 20, 2024 06:46
@skirpichev
Merge branch 'main' into sd-Py_HUGE_VAL
6a3b3ac
@skirpichev
+ damn web editor
9ad8416
AA-Turner
AA-Turner reviewed Aug 20, 2024
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few wording suggestions.

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/C API/2024-06-04-13-38-44.gh-issue-120026.uhEvJ9.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Include/pymath.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev @AA-Turner
Apply suggestions from code review
9abcb58 
Co-authored-by: Adam Turner <[email protected]>
@skirpichev
skirpichev requested a review from AA-Turner August 20, 2024 09:47
@skirpichev
Merge branch 'main' into sd-Py_HUGE_VAL
a445edb
@skirpichev

skirpichev commented Oct 31, 2024

Copy link
Copy Markdown
Member Author

CC @vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Nov 1, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
skirpichev added 3 commits November 1, 2024 19:17
@skirpichev
address review: 3.14.rst
d221527
@skirpichev
Merge branch 'master' into sd-Py_HUGE_VAL
8a8c2ec
@skirpichev
move news
881bddf
vstinner
vstinner approved these changes Nov 1, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 1, 2024
@vstinner
vstinner enabled auto-merge (squash) November 1, 2024 16:27
@vstinner
vstinner merged commit 8477951 into python:main Nov 1, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 1, 2024
@skirpichev
skirpichev deleted the sd-Py_HUGE_VAL branch November 2, 2024 03:13
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@skirpichev @AA-Turner @picnixz
pythongh-120026: soft deprecate Py_HUGE_VAL macro (python#120027)
ac54828 
Co-authored-by: Adam Turner <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@skirpichev @AA-Turner @ebonnal
pythongh-120026: soft deprecate Py_HUGE_VAL macro (python#120027)
e19acbd 
Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@skirpichev @vstinner @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.