GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-117657: Fix TSAN race involving import lock (GH-118523) by miss-islington · Pull Request #120169 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 6, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This adds a _PyRecursiveMutex type based on PyMutex and uses that
for the import lock. This fixes some data races in the free-threaded
build and generally simplifies the import lock code.
(cherry picked from commit e21057b)

Co-authored-by: Sam Gross [email protected]

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury @miss-islington
pythongh-117657: Fix TSAN race involving import lock (pythonGH-118523)
c1cbacc 
This adds a `_PyRecursiveMutex` type based on `PyMutex` and uses that
for the import lock. This fixes some data races in the free-threaded
build and generally simplifies the import lock code.
(cherry picked from commit e21057b)

Co-authored-by: Sam Gross <[email protected]>
@miss-islington
miss-islington requested review from brettcannon, ericsnowcurrently, kumaraditya303, ncoghlan and warsaw as code owners June 6, 2024 17:41
@bedevere-app bedevere-app Bot added the skip news label Jun 6, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 6, 2024
gh-117657: Fix TSAN race involving import lock #118523
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jun 6, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 6, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
@colesbury
colesbury enabled auto-merge (squash) June 6, 2024 17:41
@colesbury
colesbury merged commit 517733c into python:3.13 Jun 6, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jun 6, 2024
@miss-islington
miss-islington deleted the backport-e21057b-3.13 branch January 2, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.