GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-117657: Fix TSAN race involving import lock by colesbury · Pull Request #118523 · python/cpython

Conversation

colesbury commented May 2, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

This adds a _PyRecursiveMutex type based on PyMutex and uses that for the import lock. This fixes some data races in the free-threaded build and simplifies the import lock code.

Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-117657: Use PyMutex based recursive lock for import lock

0fa9fa3

This adds a `_PyRecursiveMutex` type based on `PyMutex` and uses that
for the import lock. This fixes some data races in the free-threaded
build and generally simplifies the import lock code.

colesbury requested review from DinoV and ericsnowcurrently

May 2, 2024 20:00

colesbury requested review from brettcannon, kumaraditya303, ncoghlan and warsaw as code owners

May 2, 2024 20:00

bedevere-app Bot added the awaiting core review label

May 2, 2024

bedevere-app Bot mentioned this pull request

May 2, 2024

Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Closed

colesbury added skip news topic-free-threading 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels

May 2, 2024

bedevere-bot commented May 2, 2024

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 0fa9fa3 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label

May 2, 2024

colesbury added 3 commits

May 3, 2024 18:24


          Merge branch 'main' into pythongh-117657-import-lock

143f7eb


          Merge branch 'main' into pythongh-117657-import-lock

60f6060


          Remove fixed races

72f4797

colesbury changed the title ~~gh-117657: Use PyMutex based recursive lock for import lock~~ gh-117657: Fix TSAN race involving import lock

May 31, 2024

colesbury added the needs backport to 3.13 only security fixes label

May 31, 2024

colesbury added 3 commits

May 31, 2024 19:13


          Remove fixed race

42eaae0


          Remove another fixed race

7191cda


          Merge branch 'main' into pythongh-117657-import-lock

225e5b9

DinoV approved these changes

Jun 5, 2024

View reviewed changes

DinoV left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Jun 5, 2024

colesbury merged commit e21057b into python:main

Jun 6, 2024

colesbury deleted the gh-117657-import-lock branch

June 6, 2024 17:41

miss-islington-app Bot commented Jun 6, 2024

Copy link

Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Jun 6, 2024

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 6, 2024


          pythongh-117657: Fix TSAN race involving import lock (pythonGH-118523)

c1cbacc

This adds a `_PyRecursiveMutex` type based on `PyMutex` and uses that
for the import lock. This fixes some data races in the free-threaded
build and generally simplifies the import lock code.
(cherry picked from commit e21057b)

Co-authored-by: Sam Gross <[email protected]>

bedevere-app Bot commented Jun 6, 2024

Copy link

Copy Markdown

GH-120169 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Jun 6, 2024

colesbury added a commit that referenced this pull request

Jun 6, 2024


          [3.13] gh-117657: Fix TSAN race involving import lock (GH-118523) (#1…

517733c

…20169)

This adds a `_PyRecursiveMutex` type based on `PyMutex` and uses that
for the import lock. This fixes some data races in the free-threaded
build and generally simplifies the import lock code.
(cherry picked from commit e21057b)

Co-authored-by: Sam Gross <[email protected]>

estyxx pushed a commit to estyxx/cpython that referenced this pull request

Jul 17, 2024


          pythongh-117657: Fix TSAN race involving import lock (python#118523)

2907d44

This adds a `_PyRecursiveMutex` type based on `PyMutex` and uses that
for the import lock. This fixes some data races in the free-threaded
build and generally simplifies the import lock code.

ADKaster mentioned this pull request

Nov 11, 2024

Ports/Python3: crash in child after fork SerenityOS/serenity#25263

Closed

nico mentioned this pull request

Nov 11, 2024

CPython should not assume that pthread_self returns the same value in fork parent and child #126688

Closed

Reviewers

DinoV

DinoV approved these changes

ericsnowcurrently

Awaiting requested review from ericsnowcurrently

ericsnowcurrently is a code owner

kumaraditya303

Awaiting requested review from kumaraditya303

kumaraditya303 is a code owner

brettcannon

Awaiting requested review from brettcannon

brettcannon is a code owner

ncoghlan

Awaiting requested review from ncoghlan

ncoghlan is a code owner

warsaw

Awaiting requested review from warsaw

warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

colesbury commented May 2, 2024 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented May 2, 2024

Uh oh!

DinoV left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Jun 6, 2024

Uh oh!

bedevere-app Bot commented Jun 6, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

colesbury commented May 2, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.