GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117657: Fix TSan reported data race on ioctl_works by colesbury · Pull Request #120175 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Jun 6, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-117657: Fix TSan reported data race on ioctl_works
b5ebee7
@colesbury colesbury added skip news topic-free-threading needs backport to 3.13 only security fixes labels Jun 6, 2024
@colesbury
colesbury requested a review from DinoV June 6, 2024 19:23
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 6, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 6, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
corona10
corona10 approved these changes Jun 6, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 6, 2024
vstinner
vstinner approved these changes Jun 7, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I tested functionally that setting ioctl_works to 0 falls back on fcntl() as expected by forcing ioctl_works to 0 and by checking syscalls with strace.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aisk aisk mentioned this pull request Jun 13, 2024
gh-117657: Fix data races for set_inheritable in fileutils.c with free-threaded builds #120458
Closed
aisk
aisk reviewed Jun 13, 2024
View reviewed changes
Comment thread Python/fileutils.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
Merge branch 'main' into pythongh-117657-set-inheritable
a57e69b
@colesbury
colesbury merged commit 460cc9e into python:main Jun 17, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 17, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 17, 2024
@colesbury
colesbury deleted the gh-117657-set-inheritable branch June 17, 2024 17:23
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 17, 2024
@colesbury @miss-islington
pythongh-117657: Fix TSan reported data race on ioctl_works (pythonGH…
df6bce4 
…-120175)

(cherry picked from commit 460cc9e)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 17, 2024

Copy link
Copy Markdown

GH-120654 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 17, 2024
colesbury added a commit that referenced this pull request Jun 17, 2024
@miss-islington @colesbury
[3.13] gh-117657: Fix TSan reported data race on ioctl_works (GH-120175…
0dbb86c 
…) (#120654)

(cherry picked from commit 460cc9e)

Co-authored-by: Sam Gross <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@colesbury @mrahtz
pythongh-117657: Fix TSan reported data race on ioctl_works (python#1…
cffedc1 
…20175)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@colesbury @estyxx
pythongh-117657: Fix TSan reported data race on ioctl_works (python#1…
2c8eddd 
…20175)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk left review comments
@vstinner vstinner vstinner approved these changes
@corona10 corona10 corona10 approved these changes
@DinoV DinoV Awaiting requested review from DinoV

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@colesbury @vstinner @aisk @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.