GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-114053: Fix bad interaction of PEP 695, PEP 563 and `inspect.get_annotations` by AlexWaygood · Pull Request #120270 · python/cpython

Conversation

AlexWaygood commented Jun 8, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: typing.get_type_hints fails when passed a class with PEP 695 type parameters and PEP 563 is enabled #114053

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-114053: Fix bad interaction of PEP 695, PEP 563 and `inspect…

ac5fd65

….get_annotations`

AlexWaygood added needs backport to 3.12

only security fixes

needs backport to 3.13 only security fixes labels

Jun 8, 2024

AlexWaygood requested a review from JelleZijlstra

June 8, 2024 14:31

bedevere-app Bot mentioned this pull request

Jun 8, 2024

typing.get_type_hints fails when passed a class with PEP 695 type parameters and PEP 563 is enabled #114053

Closed

bedevere-app Bot added the awaiting core review label

Jun 8, 2024

AlexWaygood mentioned this pull request

Jun 8, 2024

Add typing_extensions.get_annotations python/typing_extensions#423

Merged

AlexWaygood added 2 commits

June 8, 2024 15:41


          don't try to be so clever in the test

99c5b44


          Update test_inspect.py

d3a3233

AlexWaygood commented Jun 8, 2024

Copy link

Copy Markdown

Member Author

While working on this PR, I spotted another bug in get_type_hints, which will be fixed in #120272.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood marked this pull request as draft

June 9, 2024 10:43

bedevere-app Bot removed the awaiting core review label

Jun 9, 2024

JelleZijlstra approved these changes

Jun 13, 2024

View reviewed changes

bedevere-app Bot added the awaiting merge label

Jun 13, 2024


          Add the beefed-up tests from the other PR

99079c6

AlexWaygood marked this pull request as ready for review

June 13, 2024 20:50

bedevere-app Bot added awaiting core review and removed awaiting merge labels

Jun 13, 2024

AlexWaygood added 2 commits

June 13, 2024 21:50


          Merge branch 'main' into getannotations-nameerror

1d7695b


          fix lint

bb3b84b

AlexWaygood enabled auto-merge (squash)

June 13, 2024 20:51

AlexWaygood merged commit 42351c3 into python:main

Jun 13, 2024

AlexWaygood deleted the getannotations-nameerror branch

June 13, 2024 21:16

miss-islington-app Bot commented Jun 13, 2024

Copy link

Copy Markdown

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting core review label

Jun 13, 2024

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 13, 2024


          pythongh-114053: Fix bad interaction of PEP 695, PEP 563 and `inspect…

1e28baa

….get_annotations` (pythonGH-120270)

(cherry picked from commit 42351c3)

Co-authored-by: Alex Waygood <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 13, 2024


          pythongh-114053: Fix bad interaction of PEP 695, PEP 563 and `inspect…

5b88dca

….get_annotations` (pythonGH-120270)

(cherry picked from commit 42351c3)

Co-authored-by: Alex Waygood <[email protected]>

bedevere-app Bot commented Jun 13, 2024

Copy link

Copy Markdown

GH-120474 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Jun 13, 2024

bedevere-app Bot commented Jun 13, 2024

Copy link

Copy Markdown

GH-120475 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Jun 13, 2024

AlexWaygood added a commit that referenced this pull request

Jun 13, 2024


          [3.12] gh-114053: Fix bad interaction of PEP 695, PEP 563 and `inspec…

…t.get_annotations` (GH-120270) (#120475)

gh-114053: Fix bad interaction of PEP 695, PEP 563 and `inspect.get_annotations` (GH-120270)
(cherry picked from commit 42351c3)

Co-authored-by: Alex Waygood <[email protected]>

AlexWaygood added a commit that referenced this pull request

Jun 13, 2024


          [3.13] gh-114053: Fix bad interaction of PEP 695, PEP 563 and `inspec…

d4174fa

…t.get_annotations` (GH-120270) (#120474)

gh-114053: Fix bad interaction of PEP 695, PEP 563 and `inspect.get_annotations` (GH-120270)
(cherry picked from commit 42351c3)

Co-authored-by: Alex Waygood <[email protected]>

AlexWaygood mentioned this pull request

Jun 15, 2024

Backport bugfixes made to how inspect.get_annotations() deals with PEP-695 python/typing_extensions#428

Merged

mrahtz pushed a commit to mrahtz/cpython that referenced this pull request

Jun 30, 2024


          pythongh-114053: Fix bad interaction of PEP 695, PEP 563 and `inspect…

6211f9d

….get_annotations` (python#120270)

estyxx pushed a commit to estyxx/cpython that referenced this pull request

Jul 17, 2024


          pythongh-114053: Fix bad interaction of PEP 695, PEP 563 and `inspect…

….get_annotations` (python#120270)

Reviewers

JelleZijlstra

JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

AlexWaygood commented Jun 8, 2024 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexWaygood commented Jun 8, 2024

Uh oh!

miss-islington-app Bot commented Jun 13, 2024

Uh oh!

bedevere-app Bot commented Jun 13, 2024

Uh oh!

bedevere-app Bot commented Jun 13, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AlexWaygood commented Jun 8, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.