GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Docs: remove temporary hardcoded links by hugovk · Pull Request #120348 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Jun 11, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

For python/docs-community#5.

Follow on from #116966.

Read the Docs is ready and we can remove the temporary hardcoded links added in #116966 (comment).

📚 Documentation preview 📚: https://cpython-previews--120348.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Docs: remove temporary hardcoded links
323e3d3
@hugovk hugovk added skip issue skip news labels Jun 11, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 11, 2024
@hugovk

hugovk commented Jun 11, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

The language dropdown look like:

image

And the version selector is now:

image

Before it was:

image

Edit: I've set "Stable" to hidden at:

image

https://readthedocs.org/dashboard/cpython-previews/version/stable/edit/

So we now see:

image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk merged commit b8484c6 into python:main Jun 16, 2024
@hugovk
hugovk deleted the docs-rm-hardcoded-rtd branch June 16, 2024 12:51
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 16, 2024
@hugovk hugovk added awaiting core review needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jun 16, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 16, 2024

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jun 16, 2024

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jun 16, 2024

Copy link
Copy Markdown

Sorry, @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b8484c6ad7fd14ca464e584b79821b4b906dd77a 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned hugovk Jun 16, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2024
@hugovk @miss-islington
Docs: remove temporary hardcoded links (pythonGH-120348)
3774149 
(cherry picked from commit b8484c6)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 16, 2024

Copy link
Copy Markdown

GH-120587 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 16, 2024
hugovk added a commit to hugovk/cpython that referenced this pull request Jun 16, 2024
@hugovk
[3.12] Docs: remove temporary hardcoded links (pythonGH-120348)
69f524e 
(cherry picked from commit b8484c6)

Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk hugovk mentioned this pull request Jun 16, 2024
Docs: Move inline JavaScript to own file to reduce duplication #119541
Merged
hugovk added a commit to hugovk/cpython that referenced this pull request Jun 16, 2024
@hugovk
[3.12] Docs: remove temporary hardcoded links (pythonGH-120348)
f2dc999 
(cherry picked from commit b8484c6)

Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk hugovk mentioned this pull request Jun 16, 2024
[3.12] Docs: remove temporary hardcoded links and move inline JS to own file (GH-120348) #120589
Merged
@bedevere-app

bedevere-app Bot commented Jun 16, 2024

Copy link
Copy Markdown

GH-120589 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jun 16, 2024
hugovk added a commit that referenced this pull request Jun 16, 2024
@miss-islington @hugovk
[3.13] Docs: remove temporary hardcoded links (GH-120348) (#120587)
96b784b 
Docs: remove temporary hardcoded links (GH-120348)
(cherry picked from commit b8484c6)

Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Jun 16, 2024
@hugovk
[3.12] Docs: remove temporary hardcoded links and move inline JS to o…
c2f0fb9 
…wn file (GH-120348) (#120589)

[3.12] Docs: remove temporary hardcoded links (GH-120348)
(cherry picked from commit b8484c6)
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@hugovk @mrahtz
Docs: remove temporary hardcoded links (python#120348)
a804b7c
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@hugovk @estyxx
Docs: remove temporary hardcoded links (python#120348)
b467ba8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

awaiting core review skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.