GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118908: Protect the REPL subprocess with a timeout in tests by pablogsal · Pull Request #120408 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Jun 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: New REPL exposes its internal imports/definitions to top-level environment #118908

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pythongh-118908: Protect the REPL subprocess with a timeout in tests
47e3511
@pablogsal
pablogsal requested review from ambv and lysnikolaou as code owners June 12, 2024 13:24
@bedevere-app bedevere-app Bot mentioned this pull request Jun 12, 2024
New REPL exposes its internal imports/definitions to top-level environment #118908
Open
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Jun 12, 2024
@pablogsal pablogsal added the needs backport to 3.13 only security fixes label Jun 12, 2024
vstinner
vstinner reviewed Jun 12, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_pyrepl/test_pyrepl.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal commented Jun 12, 2024
View reviewed changes
Comment thread Lib/test/test_pyrepl/test_pyrepl.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
Update Lib/test/test_pyrepl/test_pyrepl.py
bc9bdc7
@pablogsal
pablogsal enabled auto-merge (squash) June 12, 2024 18:08
lysnikolaou
lysnikolaou approved these changes Jun 12, 2024
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 12, 2024
@pablogsal pablogsal added the skip news label Jun 12, 2024
@pablogsal
pablogsal merged commit 3453362 into python:main Jun 12, 2024
@pablogsal
pablogsal deleted the gh-118908-2 branch June 12, 2024 19:09
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 12, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 12, 2024

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2024
@pablogsal @miss-islington
pythongh-118908: Protect the REPL subprocess with a timeout in tests (p…
55ba242 
…ythonGH-120408)

(cherry picked from commit 3453362)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 12, 2024

Copy link
Copy Markdown

GH-120430 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 12, 2024
lysnikolaou pushed a commit that referenced this pull request Jun 12, 2024
@miss-islington @pablogsal
[3.13] gh-118908: Protect the REPL subprocess with a timeout in tests (…
ff35861 
…GH-120408) (#120430)

(cherry picked from commit 3453362)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@pablogsal @mrahtz
pythongh-118908: Protect the REPL subprocess with a timeout in tests (p…
a7dc70b 
…ython#120408)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@pablogsal @estyxx
pythongh-118908: Protect the REPL subprocess with a timeout in tests (p…
06e9e62 
…ython#120408)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@lysnikolaou lysnikolaou lysnikolaou approved these changes
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pablogsal @vstinner @lysnikolaou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.