GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-83754: Use the Py_TYPE() macro by vstinner · Pull Request #120599 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 16, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Don't access directly PyObject.ob_type, but use the Py_TYPE() macro instead.

  • Issue: [C API] Avoid accessing PyObject and PyVarObject members directly: add Py_SET_TYPE() and Py_IS_TYPE(), disallow Py_TYPE(obj)=type #83754

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-83754: Use the Py_TYPE() macro
b7896eb 
Don't access directly PyObject.ob_type, but use the Py_TYPE() macro
instead.
@vstinner vstinner added the skip news label Jun 16, 2024
@vstinner
vstinner requested review from abalkin, markshannon, methane and pganssle as code owners June 16, 2024 20:46
@bedevere-app bedevere-app Bot mentioned this pull request Jun 16, 2024
[C API] Avoid accessing PyObject and PyVarObject members directly: add Py_SET_TYPE() and Py_IS_TYPE(), disallow Py_TYPE(obj)=type #83754
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 16, 2024
methane
methane approved these changes Jun 17, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 17, 2024
@vstinner
vstinner merged commit c2d5df5 into python:main Jun 17, 2024
@vstinner
vstinner deleted the py_type branch June 17, 2024 08:34
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 17, 2024
@vstinner

vstinner commented Jun 17, 2024

Copy link
Copy Markdown
Member Author

Merged, thanks for the review @methane.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@vstinner @mrahtz
pythongh-83754: Use the Py_TYPE() macro (python#120599)
a6a9b42 
Don't access directly PyObject.ob_type, but use the Py_TYPE() macro
instead.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-83754: Use the Py_TYPE() macro (python#120599)
52a8544 
Don't access directly PyObject.ob_type, but use the Py_TYPE() macro
instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @methane
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.