GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-120417: Add #noqa: F401 to tests by vstinner · Pull Request #120627 · python/cpython

Conversation

vstinner commented Jun 17, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Ignore linter "imported but unused" warnings in tests when the linter doesn't understand why the import is important.

Issue: Remove unused imports from the stdlib #120417

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner added the skip news label

Jun 17, 2024

vstinner requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners

June 17, 2024 11:33

bedevere-app Bot mentioned this pull request

Jun 17, 2024

Remove unused imports from the stdlib #120417

Closed

bedevere-app Bot added the awaiting core review label

Jun 17, 2024

picnixz approved these changes

Jun 17, 2024

View reviewed changes

Comment thread

Lib/test/test_compile.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka reviewed

Jun 17, 2024

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import_module() can be used if ImportError is converted to SkipTest.

I have some questions about global imports of names which are seem not used in the module.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test___all__.py

Comment on lines 104 to +106

		# In case _socket fails to build, make this test fail more gracefully
		# than an AttributeError somewhere deep in concurrent.futures, email
		# or unittest.
		import _socket
		import _socket # noqa: F401

serhiy-storchaka Jun 17, 2024

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not using import_module() be better?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Jun 18, 2024

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent is to get an error if the module is missing, not to skip the test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_compileall.py

		# and it can function.
		from multiprocessing.util import _cleanup_tests as multiprocessing_cleanup_tests
		from concurrent.futures import ProcessPoolExecutor
		from concurrent.futures import ProcessPoolExecutor # noqa: F401

serhiy-storchaka Jun 17, 2024

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ProcessPoolExecutor is needed?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Jun 17, 2024

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's explained in the comment, 2 lines above. It's a check to define _have_multiprocessing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_descrtut.py

		# deterministic.

		from test.support import sortdict
		from test.support import sortdict # noqa: F401

serhiy-storchaka Jun 17, 2024

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why sortdict is needed?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Jun 17, 2024

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used in doctests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_doctest/test_doctest.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_doctest/test_doctest.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_regrtest.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_regrtest.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_regrtest.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka approved these changes

Jun 18, 2024

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Jun 18, 2024


          pythongh-120417: Add #noqa: F401 to tests

9684aa1

Ignore linter "imported but unused" warnings in tests when the linter
doesn't understand why the import is important.

vstinner force-pushed the noqa_tests branch from e0791b8 to 9684aa1 Compare

June 18, 2024 15:21

vstinner commented Jun 18, 2024

Copy link

Copy Markdown

Member Author

PR rebased to squash changes and fix merge conflicts.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner enabled auto-merge (squash)

June 18, 2024 15:23

vstinner merged commit e9f4d80 into python:main

Jun 18, 2024

vstinner deleted the noqa_tests branch

June 18, 2024 15:51

bedevere-app Bot removed the awaiting merge label

Jun 18, 2024

picnixz pushed a commit to picnixz/cpython that referenced this pull request

Jun 19, 2024


          pythongh-120417: Add #noqa: F401 to tests (python#120627)

694c130

Ignore linter "imported but unused" warnings in tests when the linter
doesn't understand how the import is used.

mrahtz pushed a commit to mrahtz/cpython that referenced this pull request

Jun 30, 2024


          pythongh-120417: Add #noqa: F401 to tests (python#120627)

364df97

Ignore linter "imported but unused" warnings in tests when the linter
doesn't understand how the import is used.

estyxx pushed a commit to estyxx/cpython that referenced this pull request

Jul 17, 2024


          pythongh-120417: Add #noqa: F401 to tests (python#120627)

60df5cc

Ignore linter "imported but unused" warnings in tests when the linter
doesn't understand how the import is used.

vstinner mentioned this pull request

Mar 13, 2025

Remove unused imports - March 2025 Edition #131152

Closed

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

picnixz

picnixz approved these changes

1st1

Awaiting requested review from 1st1

1st1 is a code owner

asvetlov

Awaiting requested review from asvetlov

asvetlov is a code owner

gvanrossum

Awaiting requested review from gvanrossum

kumaraditya303

Awaiting requested review from kumaraditya303

kumaraditya303 is a code owner

willingc

Awaiting requested review from willingc

willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

vstinner commented Jun 17, 2024 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Jun 17, 2024

Choose a reason for hiding this comment

Uh oh!

vstinner Jun 18, 2024

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Jun 17, 2024

Choose a reason for hiding this comment

Uh oh!

vstinner Jun 17, 2024

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Jun 17, 2024

Choose a reason for hiding this comment

Uh oh!

vstinner Jun 17, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented Jun 18, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vstinner commented Jun 17, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.