GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-120496: Add a note about iterator thread-safe by corona10 · Pull Request #120685 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Jun 18, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Sequence iterator thread-safety #120496

📚 Documentation preview 📚: https://cpython-previews--120685.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
pythongh-120496: Add a note about iterator thread-safe
7da3d14
@corona10 corona10 added topic-free-threading needs backport to 3.13 only security fixes labels Jun 18, 2024
@corona10
corona10 requested a review from colesbury June 18, 2024 12:37
@bedevere-app bedevere-app Bot mentioned this pull request Jun 18, 2024
Sequence iterator thread-safety #120496
Closed
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting core review labels Jun 18, 2024
@corona10
corona10 requested a review from Fidget-Spinner June 18, 2024 12:37
@corona10

corona10 commented Jun 18, 2024

Copy link
Copy Markdown
Member Author

@Fidget-Spinner see #120496 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 added 2 commits June 18, 2024 21:47
@corona10
fix
abe6019
@corona10
nit
e7e46c1
Fidget-Spinner
Fidget-Spinner reviewed Jun 18, 2024
View reviewed changes
Comment thread Doc/glossary.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10 @Fidget-Spinner
Update Doc/glossary.rst
855e75c 
Co-authored-by: Ken Jin <[email protected]>
colesbury
colesbury approved these changes Jun 18, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 18, 2024
@corona10
corona10 enabled auto-merge (squash) June 18, 2024 14:48
@corona10 corona10 closed this Jun 18, 2024
auto-merge was automatically disabled June 18, 2024 14:51

Pull request was closed

@corona10 corona10 reopened this Jun 18, 2024
@corona10
corona10 enabled auto-merge (squash) June 18, 2024 14:52
@corona10
corona10 merged commit 7e189ae into python:main Jun 18, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 18, 2024

Copy link
Copy Markdown

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 18, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2024
@corona10 @miss-islington
pythongh-120496: Add a note about iterator thread-safe (pythongh-120685)
6704789 
(cherry picked from commit 7e189ae)

Co-authored-by: Donghee Na <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 18, 2024

Copy link
Copy Markdown

GH-120706 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 18, 2024
corona10 added a commit that referenced this pull request Jun 19, 2024
@miss-islington @corona10
[3.13] gh-120496: Add a note about iterator thread-safe (gh-120685) (#…
1b02811 
…120706)

gh-120496: Add a note about iterator thread-safe (gh-120685)
(cherry picked from commit 7e189ae)

Co-authored-by: Donghee Na <[email protected]>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jun 19, 2024
@corona10 @picnixz
pythongh-120496: Add a note about iterator thread-safe (pythongh-120685)
829c8b2
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@corona10 @mrahtz
pythongh-120496: Add a note about iterator thread-safe (pythongh-120685)
697fb0a
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@corona10 @estyxx
pythongh-120496: Add a note about iterator thread-safe (pythongh-120685)
f6267d7
@devdanzin devdanzin mentioned this pull request Jul 19, 2026
Sharing a dict iterator across threads double-DECREFs di_dict under free-threading #154130
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments
@colesbury colesbury colesbury approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@corona10 @colesbury @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.