GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-120686: remove unused internal c api functions by iritkatriel · Pull Request #120687 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jun 18, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #120686.

  • Issue: Removed unused internal C API functions #120686

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-120686: remove unused internal c api functions
6123c18
@iritkatriel
iritkatriel requested a review from markshannon as a code owner June 18, 2024 12:47
@bedevere-app bedevere-app Bot mentioned this pull request Jun 18, 2024
Removed unused internal C API functions #120686
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 18, 2024
@iritkatriel
Merge remote-tracking branch 'upstream/main' into pythongh-120686
8698571
@iritkatriel iritkatriel added the skip news label Jun 18, 2024
iritkatriel added 2 commits June 18, 2024 14:51
@iritkatriel
remove includes
edbc7b8
@iritkatriel
update makefile
247c115
@iritkatriel
iritkatriel requested a review from erlend-aasland as a code owner June 18, 2024 15:21
markshannon
markshannon approved these changes Jun 27, 2024
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It will be good to get rid of _Py_Identifier completely.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 27, 2024
@iritkatriel
iritkatriel merged commit 6f7acaa into python:main Jun 27, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 27, 2024
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@iritkatriel @mrahtz
pythongh-120686: remove unused internal c api functions (python#120687)
c1c34c3
@vstinner

vstinner commented Jul 1, 2024

Copy link
Copy Markdown
Member

It will be good to get rid of _Py_Identifier completely.

I tried but failed so far: https://discuss.python.org/t/c-api-how-much-private-is-the-private-py-identifier-api/29190
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@iritkatriel @estyxx
pythongh-120686: remove unused internal c api functions (python#120687)
144ab76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Removed unused internal C API functions

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @vstinner @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.