GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119182: Optimize PyUnicode_FromFormat() by vstinner · Pull Request #120796 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 20, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Use strchr() and ucs1lib_find_max_char() to optimize the code path formatting sub-strings between '%' formats.

  • Issue: [C API] Add an efficient public PyUnicodeWriter API #119182

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-119182: Optimize PyUnicode_FromFormat()
818ea52 
Use strchr() and ucs1lib_find_max_char() to optimize the code path
formatting sub-strings between '%' formats.
@vstinner vstinner added the skip news label Jun 20, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 20, 2024
[C API] Add an efficient public PyUnicodeWriter API #119182
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 20, 2024
@vstinner vstinner mentioned this pull request Jun 20, 2024
gh-119182: Decode PyUnicode_FromFormat() format string from UTF-8 #120248
Closed
@vstinner

vstinner commented Jun 20, 2024

Copy link
Copy Markdown
Member Author

Results of #120248 (comment) benchmark:

$ python3 -m pyperf compare_to ref.json change.json --table
+----------------+--------+----------------------+
| Benchmark      | ref    | change               |
+================+========+======================+
| bench 30       | 219 ns | 202 ns: 1.08x faster |
+----------------+--------+----------------------+
| bench 100      | 262 ns | 216 ns: 1.21x faster |
+----------------+--------+----------------------+
| Geometric mean | (ref)  | 1.09x faster         |
+----------------+--------+----------------------+

Benchmark hidden because not significant (1): bench 3
nineteendo and Fidget-Spinner reacted with rocket emoji
All reactions
  • 🚀 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka reviewed Jun 20, 2024
View reviewed changes
Comment thread Objects/unicodeobject.c Outdated
}

if (_PyUnicodeWriter_WriteASCIIString(writer, f, len) < 0)
int is_ascii = (ucs1lib_find_max_char((Py_UCS1*)f, (Py_UCS1*)f + len) < 128);

@serhiy-storchaka serhiy-storchaka Jun 20, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can run it once, for the whole format string.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vstinner vstinner Jun 20, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I modified my PR to run it only once, good idea!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
Run ucs1lib_find_max_char() only once
57d7152
serhiy-storchaka
serhiy-storchaka reviewed Jun 20, 2024
View reviewed changes
Comment thread Objects/unicodeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Add comment
614e132
@vstinner
vstinner enabled auto-merge (squash) June 20, 2024 18:58
@vstinner
vstinner merged commit 5150795 into python:main Jun 20, 2024
@vstinner
vstinner deleted the optim_from_fmt branch June 20, 2024 19:06
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 20, 2024
@vstinner

vstinner commented Jun 20, 2024

Copy link
Copy Markdown
Member Author

Merged, thanks for the reviews @serhiy-storchaka.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@vstinner @mrahtz
pythongh-119182: Optimize PyUnicode_FromFormat() (python#120796)
c818e2c 
Use strchr() and ucs1lib_find_max_char() to optimize the code path
formatting sub-strings between '%' formats.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-119182: Optimize PyUnicode_FromFormat() (python#120796)
ff60c66 
Use strchr() and ucs1lib_find_max_char() to optimize the code path
formatting sub-strings between '%' formats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.