GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-73991: Support copying directory symlinks on older Windows by barneygale · Pull Request #120807 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Jun 20, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Check for ERROR_INVALID_PARAMETER when calling _winapi.CopyFile2() and raise UnsupportedOperation. In Path.copy(), handle this exception and fall back to the PathBase.copy() implementation.

No news as Path.copy() is brand new.

  • Issue: Support moving across filesystems in pathlib.Path, as shutil.move() does #73991

📚 Documentation preview 📚: https://cpython-previews--120807.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
pythonGH-73991: Support copying directory symlinks on older Windows
9ebc001 
Check for `ERROR_INVALID_PARAMETER` when calling `_winapi.CopyFile2()` and
raise `UnsupportedOperation`. In `Path.copy()`, handle this exception and
fall back to the `PathBase.copy()` implementation.
@barneygale barneygale added skip news topic-pathlib labels Jun 20, 2024
@barneygale
barneygale requested a review from eryksun June 20, 2024 18:52
@bedevere-app bedevere-app Bot mentioned this pull request Jun 20, 2024
Support moving across filesystems in pathlib.Path, as shutil.move() does #73991
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 20, 2024
eryksun
eryksun reviewed Jun 20, 2024
View reviewed changes
Comment thread Lib/pathlib/_os.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
eryksun
eryksun reviewed Jun 20, 2024
View reviewed changes
Comment thread Lib/pathlib/_os.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
Address review comments
09e3601
@barneygale
barneygale requested review from eryksun and zooba June 27, 2024 18:11
eryksun
eryksun approved these changes Jun 27, 2024
View reviewed changes

@eryksun eryksun left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this. 🚀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
barneygale reacted with hooray emoji barneygale reacted with heart emoji barneygale reacted with rocket emoji
All reactions
  • 🎉 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction
@barneygale

barneygale commented Jul 3, 2024

Copy link
Copy Markdown
Contributor Author

Thank you Eryk!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
barneygale merged commit f09d184 into python:main Jul 3, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 3, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@barneygale @estyxx
pythonGH-73991: Support copying directory symlinks on older Windows (p…
09d6efa 
…ython#120807)

Check for `ERROR_INVALID_PARAMETER` when calling `_winapi.CopyFile2()` and
raise `UnsupportedOperation`. In `Path.copy()`, handle this exception and
fall back to the `PathBase.copy()` implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eryksun eryksun eryksun approved these changes
@zooba zooba Awaiting requested review from zooba

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@barneygale @eryksun
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.