GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118507: Amend news entry by nineteendo · Pull Request #120817 · python/cpython

Conversation

@nineteendo

@nineteendo nineteendo commented Jun 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adds extra information only present in the backport to the 3.12 branch.

  • Issue: Refactor nt._path_is* & nt._path_[l]exists #118507

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nineteendo
Update 2024-05-08-18-33-07.gh-issue-118507.OCQsAY.rst
da996d9
@bedevere-app bedevere-app Bot added the docs Documentation in the Doc dir label Jun 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 21, 2024
Refactor nt._path_is* & nt._path_[l]exists #118507
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jun 21, 2024
@nineteendo
Merge branch 'main' into amend-news-entry
9970578
@nineteendo

nineteendo commented Jul 4, 2024

Copy link
Copy Markdown
Contributor Author

cc @zooba
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented Jul 4, 2024

Copy link
Copy Markdown
Member

I'm unclear. This PR is against main, which means we'll be announcing that pipes were fixed in 3.14 - why do you say it is only in 3.12?

Which branches need this change?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nineteendo

nineteendo commented Jul 4, 2024

Copy link
Copy Markdown
Contributor Author

That's correct, pipes were fixed in 3.13 and 3.14, but only the speedup to os.path.isjunction() and os.path.lexists() was mentioned. I only mentioned this fix in the backport to 3.12.
zooba reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba zooba added the needs backport to 3.13 only security fixes label Jul 4, 2024
@zooba
zooba merged commit db17291 into python:main Jul 4, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jul 4, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 4, 2024

Copy link
Copy Markdown

Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 4, 2024

Copy link
Copy Markdown

Sorry, @nineteendo and @zooba, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker db1729143de0775c99e0453cb0fc01a799f289a0 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned zooba Jul 4, 2024
@nineteendo
nineteendo deleted the amend-news-entry branch July 4, 2024 14:58
@bedevere-app

bedevere-app Bot commented Jul 4, 2024

Copy link
Copy Markdown

GH-121365 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 4, 2024
zooba added a commit that referenced this pull request Jul 4, 2024
@zooba
gh-118507: Amend news entry to mention ntpath.isfile bugfix (GH-120817)
868e9ab
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@nineteendo @estyxx
pythongh-118507: Amend news entry to mention ntpath.isfile bugfix (py…
1aa1017 
…thonGH-120817)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zooba zooba

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nineteendo @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.