GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119182: Add PyUnicodeWriter_WriteUCS4() function by vstinner · Pull Request #120849 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 21, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: [C API] Add an efficient public PyUnicodeWriter API #119182

📚 Documentation preview 📚: https://cpython-previews--120849.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot mentioned this pull request Jun 21, 2024
[C API] Add an efficient public PyUnicodeWriter API #119182
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 21, 2024
@vstinner
vstinner force-pushed the writer_ucs4 branch from 169d423 to fc7173a Compare June 21, 2024 18:40
@vstinner
pythongh-119182: Add PyUnicodeWriter_WriteUCS4() function
d6d0203
@vstinner
vstinner force-pushed the writer_ucs4 branch from fc7173a to d6d0203 Compare June 21, 2024 18:42
@vstinner

vstinner commented Jun 21, 2024

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka @encukou
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka reviewed Jun 24, 2024
View reviewed changes
Comment thread Doc/c-api/unicode.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner added 4 commits June 24, 2024 14:32
@vstinner
Merge branch 'main' into writer_ucs4
4635f5f
@vstinner
size must be positive
aefcbf8
@vstinner
Use PyUnicodeWriter_WriteUCS4() on Solaris
e18a47c
@vstinner
Fix typo
056c42e
serhiy-storchaka
serhiy-storchaka reviewed Jun 24, 2024
View reviewed changes
Comment thread Lib/test/test_capi/test_unicode.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner added 2 commits June 24, 2024 15:13
@vstinner
Update tests
8c7691a
@vstinner
Add more tests
76e66dd
serhiy-storchaka
serhiy-storchaka approved these changes Jun 24, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 24, 2024
@vstinner
vstinner merged commit 2e15785 into python:main Jun 24, 2024
@vstinner
vstinner deleted the writer_ucs4 branch June 24, 2024 15:40
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 24, 2024
@vstinner

vstinner commented Jun 24, 2024

Copy link
Copy Markdown
Member Author

Merged, thanks for the review @serhiy-storchaka.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@vstinner @mrahtz
pythongh-119182: Add PyUnicodeWriter_WriteUCS4() function (python#120849
27e5263 
)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-119182: Add PyUnicodeWriter_WriteUCS4() function (python#120849
cdc2954 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.