GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-120804: Remove `PidfdChildWatcher`, `ThreadedChildWatcher` and `AbstractChildWatcher` from asyncio APIs by kumaraditya303 · Pull Request #120893 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Jun 23, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Rewrite asyncio subprocesses without child watchers  #120804

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kumaraditya303 added 2 commits June 23, 2024 04:44
@kumaraditya303
remove threaded and pidfd child watchers
b438e52
@kumaraditya303
add test
23112b1
@kumaraditya303 kumaraditya303 added topic-asyncio skip news labels Jun 23, 2024
@kumaraditya303
kumaraditya303 requested review from 1st1, asvetlov, gvanrossum and willingc as code owners June 23, 2024 05:03
@bedevere-app bedevere-app Bot mentioned this pull request Jun 23, 2024
Rewrite asyncio subprocesses without child watchers #120804
Closed
5 tasks done
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 23, 2024
@kumaraditya303
kumaraditya303 merged commit 9d2e1ea into python:main Jun 23, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 23, 2024
@kumaraditya303
kumaraditya303 deleted the watcher branch June 23, 2024 13:08
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@kumaraditya303 @mrahtz
pythonGH-120804: Remove PidfdChildWatcher, ThreadedChildWatcher a…
4d8d2dc 
…nd `AbstractChildWatcher` from asyncio APIs (python#120893)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@kumaraditya303 @estyxx
pythonGH-120804: Remove PidfdChildWatcher, ThreadedChildWatcher a…
11ec705 
…nd `AbstractChildWatcher` from asyncio APIs (python#120893)
@allisonkarlitskaya

allisonkarlitskaya commented Mar 6, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

hi,

Where was it documented that PidfdChildWatcher was deprecated and slated for removal?

https://docs.python.org/3/library/asyncio-policy.html#asyncio.PidfdChildWatcher shows only "added in 3.9". We specifically added a check for this class by name because of the pending deprecation of SafeChildWatcher (which is indeed marked as "Deprecated since version 3.12." on the same page) and now our code is broken with Python 3.14...

See https://bugzilla.redhat.com/show_bug.cgi?id=2350287
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@allisonkarlitskaya allisonkarlitskaya mentioned this pull request Mar 6, 2025
PidfdChildWatcher removed without deprecation #130915
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kumaraditya303 @allisonkarlitskaya
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.