GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-120937: Reference weakref from the __del__ documentation by chaen · Pull Request #120940 · python/cpython

Conversation

@chaen

@chaen chaen commented Jun 24, 2024 •
edited by hugovk
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

#120937

The weakref documentation refers to __del__, but not the other way around.

I am not sure the phrasing (copy/paste from weakref doc) is the best one, but it seems important to me redirect developers to what they are most probably looking for.

📚 Documentation preview 📚: https://cpython-previews--120940.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chaen
pythongh-120937: Reference weakref from the __del__ documentation
ffafa4d 
The weakref documentation refers to __del__, but not
the other way around.
@ghost

ghost commented Jun 24, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the docs Documentation in the Doc dir label Jun 24, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 24, 2024
__del__ documentation does not mention weakref #120937
Closed
@bedevere-app bedevere-app Bot added skip news awaiting review labels Jun 24, 2024
sobolevn
sobolevn approved these changes Jun 25, 2024
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 25, 2024
@sobolevn
sobolevn requested a review from hugovk June 25, 2024 11:40
hugovk
hugovk reviewed Jun 25, 2024
View reviewed changes
Comment thread Doc/reference/datamodel.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
Update Doc/reference/datamodel.rst
cb13db9
@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jun 26, 2024
hugovk
hugovk approved these changes Jun 26, 2024
View reviewed changes
Eclips4
Eclips4 approved these changes Jun 26, 2024
View reviewed changes
@sobolevn
sobolevn merged commit 1c13b29 into python:main Jun 26, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 26, 2024

Copy link
Copy Markdown

Thanks @chaen for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 26, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2024
@chaen @hugovk @miss-islington
pythongh-120937: Reference weakref from the __del__ documentation (p…
1950dd4 
…ythonGH-120940)

(cherry picked from commit 1c13b29)

Co-authored-by: chaen <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 26, 2024

Copy link
Copy Markdown

GH-121061 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 26, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2024
@chaen @hugovk @miss-islington
pythongh-120937: Reference weakref from the __del__ documentation (p…
bc7c48c 
…ythonGH-120940)

(cherry picked from commit 1c13b29)

Co-authored-by: chaen <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 26, 2024

Copy link
Copy Markdown

GH-121062 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jun 26, 2024
sobolevn pushed a commit that referenced this pull request Jun 26, 2024
@miss-islington @chaen @hugovk
[3.12] gh-120937: Reference weakref from the __del__ documentation (G…
709ef00 
…H-120940) (#121062)

gh-120937: Reference weakref from the `__del__` documentation (GH-120940)
(cherry picked from commit 1c13b29)

Co-authored-by: chaen <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
sobolevn pushed a commit that referenced this pull request Jun 26, 2024
@miss-islington @chaen @hugovk
[3.13] gh-120937: Reference weakref from the __del__ documentation (G…
d7cd71c 
…H-120940) (#121061)

gh-120937: Reference weakref from the `__del__` documentation (GH-120940)
(cherry picked from commit 1c13b29)

Co-authored-by: chaen <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@chaen @hugovk @mrahtz
pythongh-120937: Reference weakref from the __del__ documentation (p…
1c991d4 
…ython#120940)

Co-authored-by: Hugo van Kemenade <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@chaen @hugovk @estyxx
pythongh-120937: Reference weakref from the __del__ documentation (p…
af9b173 
…ython#120940)

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@sobolevn sobolevn sobolevn approved these changes
@Eclips4 Eclips4 Eclips4 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@chaen @hugovk @sobolevn @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.