GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (GH-120822) by miss-islington · Pull Request #120985 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 25, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add missing space in AS_VAR_APPEND() on CFLAGS.
(cherry picked from commit 2106c9b)

Co-authored-by: Michael Allwright [email protected]

  • Issue: Failing configure tests due to missing space #120671

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@allsey87 @miss-islington
pythongh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (pythonGH-…
fe2912e 
…120822)

Add missing space in AS_VAR_APPEND() on CFLAGS.
(cherry picked from commit 2106c9b)

Co-authored-by: Michael Allwright <[email protected]>
@miss-islington
miss-islington requested review from corona10 and erlend-aasland as code owners June 25, 2024 07:48
This was referenced Jun 25, 2024
Failing configure tests due to missing space #120671
Closed
gh-120671: Fix as_fn_append CFLAGS #120822
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jun 25, 2024
@vstinner
vstinner enabled auto-merge (squash) June 25, 2024 07:49
@vstinner
vstinner merged commit d26ce50 into python:3.13 Jun 25, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jun 25, 2024
@miss-islington
miss-islington deleted the backport-2106c9b-3.13 branch January 2, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @vstinner @allsey87
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.