GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-120671: Fix as_fn_append CFLAGS by allsey87 · Pull Request #120822 · python/cpython

Conversation

@allsey87

@allsey87 allsey87 commented Jun 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This fixes an issue with failing configure tests due to a missing space when appending to CFLAGS. @eli-schwartz tracked down the source of this bug as follows:

In commit 76d14fa (GH-29485), some code was refactored to be more compact and use more advanced autoconf tricks. In the process, it switched

AS_VAR_SET([XXX], ["$XXX other values"])

to

AS_VAR_APPEND([XXX], ["other values"])

This was a functional logic break, since it elided the space in between the existing and appended values -- and that space is mandatory for command-line flags stuffed into a variable.

The same problem occurred for LDFLAGS, but was silently fixed as a side effect of commit bb8b931 (GH-32229).

Resolves #120671

  • Issue: Failing configure tests due to missing space #120671

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@allsey87
Fix as_fn_append CFLAGS
f5a4f87
@allsey87
allsey87 requested review from corona10 and erlend-aasland as code owners June 21, 2024 08:48
@bedevere-app bedevere-app Bot mentioned this pull request Jun 21, 2024
Failing configure tests due to missing space #120671
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jun 21, 2024
@allsey87

allsey87 commented Jun 21, 2024

Copy link
Copy Markdown
Contributor Author

Note that this issue with a missing space might also be true of configure.ac#L7548.
erlend-aasland reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland self-assigned this Jun 21, 2024
@erlend-aasland erlend-aasland added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jun 21, 2024
erlend-aasland
erlend-aasland approved these changes Jun 21, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 21, 2024
@erlend-aasland

erlend-aasland commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

Note that this issue with a missing space might also be true of configure.ac#L7548.

No, that's not an issue. It's the # that prepends some extension module build variables. See for example Modules/Setup.stdlib.in
allsey87 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

Can you supply a NEWS entry?
allsey87 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blurb-it
📜🤖 Added by blurb_it.
7848e9b
zware
zware approved these changes Jun 25, 2024
View reviewed changes
@vstinner
vstinner merged commit 2106c9b into python:main Jun 25, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 25, 2024

Copy link
Copy Markdown

Thanks @allsey87 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 25, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 25, 2024
@allsey87 @miss-islington
pythongh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (pythonGH-…
fe2912e 
…120822)

Add missing space in AS_VAR_APPEND() on CFLAGS.
(cherry picked from commit 2106c9b)

Co-authored-by: Michael Allwright <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 25, 2024

Copy link
Copy Markdown

GH-120985 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 25, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 25, 2024
@allsey87 @miss-islington
pythongh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (pythonGH-…
42bec11 
…120822)

Add missing space in AS_VAR_APPEND() on CFLAGS.
(cherry picked from commit 2106c9b)

Co-authored-by: Michael Allwright <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 25, 2024

Copy link
Copy Markdown

GH-120986 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jun 25, 2024
@vstinner

vstinner commented Jun 25, 2024

Copy link
Copy Markdown
Member

Merged, thanks.
allsey87 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner pushed a commit that referenced this pull request Jun 25, 2024
@miss-islington @allsey87
[3.12] gh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (GH-120822)…
433a5f8 
… (#120986)

gh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (GH-120822)

Add missing space in AS_VAR_APPEND() on CFLAGS.
(cherry picked from commit 2106c9b)

Co-authored-by: Michael Allwright <[email protected]>
vstinner pushed a commit that referenced this pull request Jun 25, 2024
@miss-islington @allsey87
[3.13] gh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (GH-120822)…
d26ce50 
… (#120985)

gh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (GH-120822)

Add missing space in AS_VAR_APPEND() on CFLAGS.
(cherry picked from commit 2106c9b)

Co-authored-by: Michael Allwright <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@allsey87 @mrahtz
pythongh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (python#12…
02eccfc 
…0822)

Add missing space in AS_VAR_APPEND() on CFLAGS.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@allsey87 @estyxx
pythongh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (python#12…
c49e6d3 
…0822)

Add missing space in AS_VAR_APPEND() on CFLAGS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@erlend-aasland erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failing configure tests due to missing space

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@allsey87 @erlend-aasland @vstinner @zware
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.