GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121016: Add test for `PYTHON_BASIC_REPL` envioronment variable by devdanzin · Pull Request #121017 · python/cpython

Conversation

@devdanzin

@devdanzin devdanzin commented Jun 26, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR adds a test for PYTHON_BASIC_REPL setting the interpreter to use the basic REPL, using a technique suggested by @AlexWaygood on Discord.

  • Issue: PYTHON_BASIC_REPL is not currently tested #121016

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
devdanzin added 2 commits June 25, 2024 16:59
@devdanzin
Test that PYTHON_BASIC_REPL works to set the REPL to basic.
4001f3d
@devdanzin
Guard test_python_basic_repl against PyREPL not being available.
7baa95b
@devdanzin
devdanzin requested review from ambv, lysnikolaou and pablogsal as code owners June 26, 2024 01:12
@bedevere-app bedevere-app Bot mentioned this pull request Jun 26, 2024
PYTHON_BASIC_REPL is not currently tested #121016
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jun 26, 2024
@sobolevn sobolevn added the skip news label Jun 26, 2024
lysnikolaou
lysnikolaou approved these changes Jun 26, 2024
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @devdanzin!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 26, 2024
@lysnikolaou lysnikolaou added needs backport to 3.13 only security fixes topic-repl Related to the interactive shell labels Jun 26, 2024
AlexWaygood
AlexWaygood reviewed Jun 26, 2024
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Two tiny nits:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_pyrepl/test_pyrepl.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_pyrepl/test_pyrepl.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@devdanzin @AlexWaygood
Apply suggestions from code review to double-check that the tests are…
0f0ee39 
… working as expected.

Co-authored-by: Alex Waygood <[email protected]>
@devdanzin

devdanzin commented Jun 26, 2024

Copy link
Copy Markdown
Member Author

Thank you Lysandros and Alex!
AlexWaygood and lysnikolaou reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood approved these changes Jun 26, 2024
View reviewed changes
@AlexWaygood AlexWaygood changed the title gh-121016: Test PYTHON_BASIC_REPL gh-121016: Add test for PYTHON_BASIC_REPL envioronment variable Jun 26, 2024
@AlexWaygood
AlexWaygood enabled auto-merge (squash) June 26, 2024 09:59
@AlexWaygood
AlexWaygood merged commit 9e45fd9 into python:main Jun 26, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 26, 2024

Copy link
Copy Markdown

Thanks @devdanzin for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 26, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 26, 2024

Copy link
Copy Markdown

Sorry, @devdanzin and @AlexWaygood, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9e45fd9858a059950f7387b4fda2b00df0e8e537 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned AlexWaygood Jun 26, 2024
@AlexWaygood

AlexWaygood commented Jun 26, 2024

Copy link
Copy Markdown
Member

@devdanzin, would you possibly be able to take care of the backport PR? If you're not familiar with the process, I can do it later
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@devdanzin

devdanzin commented Jun 26, 2024

Copy link
Copy Markdown
Member Author

Thanks for merging!

@devdanzin, would you possibly be able to take care of the backport PR?

I'm not sure I can, I get "Permission denied" at the end of the process:

🐍 🍒 ⛏
Failed to push to origin ☹
branch backport-9e45fd9-3.13 has been deleted.

Backport PR:

[3.13] gh-121016: Add test for `PYTHON_BASIC_REPL` envioronment variable (GH-121017)
(cherry picked from commit 9e45fd9858a059950f7387b4fda2b00df0e8e537)

Co-authored-by: devdanzin <[email protected]>
remote: Permission to python/cpython.git denied to devdanzin.
fatal: unable to access 'https://github.com/python/cpython.git/': The requested URL returned error: 403

If the right way to do it is to push to my fork first, I can try it tonight. Otherwise, feel free to handle it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou

lysnikolaou commented Jun 26, 2024

Copy link
Copy Markdown
Member

If the right way to do it is to push to my fork first, I can try it tonight. Otherwise, feel free to handle it.

That's the right way, yes. You can try it tonight, sure.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
devdanzin added a commit to devdanzin/cpython that referenced this pull request Jun 26, 2024
@devdanzin
pythongh-121016: Add test for PYTHON_BASIC_REPL envioronment variab…
547f13d 
…le (python#121017)

(cherry picked from commit 9e45fd9)
devdanzin added a commit to devdanzin/cpython that referenced this pull request Jun 26, 2024
@devdanzin
[3.13] pythongh-121016: Add test for PYTHON_BASIC_REPL envioronment…
1ac30d5 
… variable (pythonGH-121017)

(cherry picked from commit 9e45fd9)

Co-authored-by: devdanzin <[email protected]>
devdanzin added a commit to devdanzin/cpython that referenced this pull request Jun 26, 2024
@devdanzin
pythongh-121016: Add test for PYTHON_BASIC_REPL envioronment variab…
4ecdb52 
…le (python#121017)

(cherry picked from commit 9e45fd9)
devdanzin added a commit to devdanzin/cpython that referenced this pull request Jun 26, 2024
@devdanzin
[3.13] pythongh-121016: Add test for PYTHON_BASIC_REPL envioronment…
65f456b 
… variable (pythonGH-121017)

(cherry picked from commit 9e45fd9)

Co-authored-by: devdanzin <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 26, 2024

Copy link
Copy Markdown

GH-121064 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 26, 2024
AlexWaygood pushed a commit that referenced this pull request Jun 26, 2024
@devdanzin
[3.13] gh-121016: Add test for PYTHON_BASIC_REPL envioronment variable (
bc515b3 
GH-121017) (#121064)

* gh-121016: Add test for `PYTHON_BASIC_REPL` envioronment variable (#121017)

(cherry picked from commit 9e45fd9)

* [3.13] gh-121016: Add test for `PYTHON_BASIC_REPL` envioronment variable (GH-121017)
(cherry picked from commit 9e45fd9)

Co-authored-by: devdanzin <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@devdanzin @mrahtz
pythongh-121016: Add test for PYTHON_BASIC_REPL envioronment variab…
bcd4204 
…le (python#121017)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@devdanzin @estyxx
pythongh-121016: Add test for PYTHON_BASIC_REPL envioronment variab…
73474bb 
…le (python#121017)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AlexWaygood AlexWaygood

Labels

skip news topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@devdanzin @AlexWaygood @lysnikolaou @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.