GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121040: Remove fallthrough warnings compiler option by nohlson · Pull Request #121041 · python/cpython

Conversation

@nohlson

@nohlson nohlson commented Jun 26, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Until tooling is implemented remove -Wimplicit-fallthrough compiler flag from BASEFLAGS

  • Issue: -Wimplicit-fallthrough generating warnings #121040

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nohlson
Remove fallthrough warnings
8034f74
@nohlson
nohlson requested review from corona10 and erlend-aasland as code owners June 26, 2024 09:43
@bedevere-app bedevere-app Bot added the awaiting review label Jun 26, 2024
corona10
corona10 approved these changes Jun 26, 2024
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 26, 2024
@corona10 corona10 changed the title gh-#121040: Remove fallthrough warnings gh-121040: Remove fallthrough warnings Jun 26, 2024
@corona10 corona10 added the skip news label Jun 26, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 26, 2024
-Wimplicit-fallthrough generating warnings #121040
Closed
@corona10
corona10 enabled auto-merge (squash) June 26, 2024 09:45
@corona10
corona10 disabled auto-merge June 26, 2024 09:45
@corona10
corona10 enabled auto-merge (squash) June 26, 2024 09:45
@corona10 corona10 changed the title gh-121040: Remove fallthrough warnings gh-121040: Remove fallthrough warnings compiler option Jun 26, 2024
@nohlson nohlson mentioned this pull request Jun 26, 2024
Consider applying flags for warnings about potential security issues #112301
Closed
@corona10
corona10 merged commit ef28f6d into python:main Jun 26, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 26, 2024
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@nohlson @mrahtz
pythongh-121040: Remove fallthrough warnings compiler option (pythong…
c8152ac 
…h-121041)

Remove fallthrough warnings
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@nohlson @estyxx
pythongh-121040: Remove fallthrough warnings compiler option (pythong…
73a8f4b 
…h-121041)

Remove fallthrough warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nohlson @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.