GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121008: Fix idlelib.run tests by vstinner · Pull Request #121046 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 26, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

When testing IDLE, don't create a Tk to avoid side effects such as installing a PyOS_InputHook hook.

  • Issue: test_pyrepl: test_cursor_back_write() blocks on input_hook() when tests are run sequentially #121008

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ambv reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vstinner
pythongh-121008: Fix idlelib.run tests
a9f3f4b 
When testing IDLE, don't create a Tk to avoid side effects such as
installing a PyOS_InputHook hook.
@vstinner vstinner added skip news needs backport to 3.13 only security fixes labels Jun 26, 2024
@vstinner
vstinner requested a review from terryjreedy as a code owner June 26, 2024 13:14
@bedevere-app bedevere-app Bot mentioned this pull request Jun 26, 2024
test_pyrepl: test_cursor_back_write() blocks on input_hook() when tests are run sequentially #121008
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 26, 2024
@vstinner

vstinner commented Jun 26, 2024

Copy link
Copy Markdown
Member Author

Without this change, ./python -m test -u all,-gui test_idle test_pyrepl hangs on Linux: it is blocked until I press ENTER.

With this change, the same command no longer hangs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ambv
ambv approved these changes Jun 26, 2024
View reviewed changes

@ambv ambv left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue for me on Ubuntu and macOS, both GUI builds. Tests pass with:

> /Volumes/RAMDisk/installed-main/bin/python3 -E -Wd -m test --slowest --fail-env-changed -uall test_idle test_pyrepl
Using random seed: 2738848300
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 9.16 Run 2 tests sequentially in a single process
0:00:00 load avg: 9.16 [1/2] test_idle
0:00:09 load avg: 9.14 [2/2] test_pyrepl

== Tests result: SUCCESS ==

10 slowest tests:
- test_idle: 9.3 sec
- test_pyrepl: 4.5 sec

All 2 tests OK.

Total duration: 13.9 sec
Total tests: run=740 skipped=5
Total test files: run=2/2
Result: SUCCESS

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 26, 2024
@vstinner
vstinner merged commit 44eafd6 into python:main Jun 26, 2024
@vstinner
vstinner deleted the idle branch June 26, 2024 13:41
@miss-islington-app

miss-islington-app Bot commented Jun 26, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 26, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2024
@vstinner @miss-islington
pythongh-121008: Fix idlelib.run tests (pythonGH-121046)
08435c2 
When testing IDLE, don't create a Tk to avoid side effects such as
installing a PyOS_InputHook hook.
(cherry picked from commit 44eafd6)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 26, 2024

Copy link
Copy Markdown

GH-121049 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 26, 2024
@vstinner

vstinner commented Jun 26, 2024

Copy link
Copy Markdown
Member Author

Ok, let me merge this change and see how it goes.

Thanks for the review @ambv.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit that referenced this pull request Jun 26, 2024
@miss-islington @vstinner
[3.13] gh-121008: Fix idlelib.run tests (GH-121046) (#121049)
bdcc738 
gh-121008: Fix idlelib.run tests (GH-121046)

When testing IDLE, don't create a Tk to avoid side effects such as
installing a PyOS_InputHook hook.
(cherry picked from commit 44eafd6)

Co-authored-by: Victor Stinner <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@vstinner @mrahtz
pythongh-121008: Fix idlelib.run tests (python#121046)
8936462 
When testing IDLE, don't create a Tk to avoid side effects such as
installing a PyOS_InputHook hook.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-121008: Fix idlelib.run tests (python#121046)
c1514f7 
When testing IDLE, don't create a Tk to avoid side effects such as
installing a PyOS_InputHook hook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv approved these changes
@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.