GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-121039: add Floats/ComplexesAreIdenticalMixin to test.support.testcase by skirpichev · Pull Request #121071 · python/cpython

Conversation

skirpichev commented Jun 27, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Add assertFloatsAreIdentical/assertComplexAreIdentical to unittest (or kwarg to assertEqual)? #121039

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-121039: add Floats/ComplexesAreIdenticalMixin to test.suppor…

d10eef8

…t.testcase

bedevere-app Bot mentioned this pull request

Jun 27, 2024

Add assertFloatsAreIdentical/assertComplexAreIdentical to unittest (or kwarg to assertEqual)? #121039

Closed

bedevere-app Bot added the awaiting review label

Jun 27, 2024

This comment was marked as outdated.


          Merge branch 'main' into num-areidentical-mixin-121039

2a2f9af

skirpichev mentioned this pull request

Jun 27, 2024

gh-61103: support double complex (_Complex) type in ctypes #120894

Merged

sobolevn approved these changes

Jun 27, 2024

View reviewed changes

sobolevn left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good refactoring, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting review labels

Jun 27, 2024

sobolevn added the skip news label

Jun 27, 2024

sobolevn commented Jun 27, 2024

Copy link

Copy Markdown

Member

Build failure is not related and is reported here #121065

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

skirpichev commented Jun 27, 2024

Copy link

Copy Markdown

Member Author

There are more cases, which could be changed, some were mentioned in the issue. But I'm not sure it worth - stopping reinvent the wheel in new tests seems enough.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

skirpichev added 3 commits

June 28, 2024 03:47


          Merge branch 'main' into num-areidentical-mixin-121039

0a1901d


          Merge branch 'master' into num-areidentical-mixin-121039

b5644eb


          + adapt Lib/test/test_ctypes/test_numbers.py

4fc14b7

skirpichev commented Jul 10, 2024

Copy link

Copy Markdown

Member Author

Unfortunately, #120894 was merged first. Yet one place to refactor, fixed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

skirpichev mentioned this pull request

Jul 12, 2024

gh-121249: Support _Complex types in the struct module #121613

Merged

skirpichev mentioned this pull request

Sep 8, 2024

Issue with Round Function in Python #123811

Closed

serhiy-storchaka approved these changes

Sep 8, 2024

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka commented Sep 8, 2024

Copy link

Copy Markdown

Member

I think that test_capi/test_getargs.py is a fair case, and pretty simple too.

Cases in test_math.py are more complex.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka and others added 2 commits

September 8, 2024 13:41


          Merge branch 'main' into num-areidentical-mixin-121039

87d9850


          address review: add mixin to test_getargs.py

01036e6

skirpichev commented Sep 8, 2024

Copy link

Copy Markdown

Member Author

I think that test_capi/test_getargs.py is a fair case, and pretty simple too.

Yeah, added this.

Cases in test_math.py are more complex.

Some seems mechanical too (assertEqualSign helper). But I'm not sure if this worth it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

skirpichev requested a review from serhiy-storchaka

September 8, 2024 10:54

serhiy-storchaka approved these changes

Sep 8, 2024

View reviewed changes

serhiy-storchaka merged commit 8ef8354 into python:main

Sep 8, 2024

bedevere-app Bot removed the awaiting merge label

Sep 8, 2024

serhiy-storchaka added needs backport to 3.12

only security fixes

needs backport to 3.13 only security fixes labels

Sep 8, 2024

miss-islington-app Bot commented Sep 8, 2024

Copy link

Copy Markdown

Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Sep 8, 2024

Copy link

Copy Markdown

Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Sep 8, 2024

Copy link

Copy Markdown

Sorry, @skirpichev and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8ef8354ef15e00d484ac2ded9442b789c24b11e0 3.13

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot assigned serhiy-storchaka

Sep 8, 2024

miss-islington-app Bot commented Sep 8, 2024

Copy link

Copy Markdown

Sorry, @skirpichev and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8ef8354ef15e00d484ac2ded9442b789c24b11e0 3.12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added the tests Tests in the Lib/test dir label

Sep 8, 2024

skirpichev deleted the num-areidentical-mixin-121039 branch

September 8, 2024 13:21

skirpichev commented Sep 8, 2024

Copy link

Copy Markdown

Member Author

I'm working on backports.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

skirpichev added a commit to skirpichev/cpython that referenced this pull request

Sep 8, 2024


          redo on top of python#121071

42c3783

skirpichev added a commit to skirpichev/cpython that referenced this pull request

Sep 8, 2024


          [3.13] pythongh-121039: add Floats/ComplexesAreIdenticalMixin to test…

5fe5b0e

….support.testcase (pythonGH-121071)

(cherry picked from commit 8ef8354)

Co-authored-by: Sergey B Kirpichev <[email protected]>

bedevere-app Bot commented Sep 8, 2024

Copy link

Copy Markdown

GH-123840 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Sep 8, 2024

bedevere-app Bot commented Sep 8, 2024

Copy link

Copy Markdown

GH-123841 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Sep 8, 2024

vstinner pushed a commit that referenced this pull request

Sep 11, 2024


          [3.12] gh-121039: add Floats/ComplexesAreIdenticalMixin to test.suppo…

ec119dc

…rt.testcase (GH-121071) (#123841)

* [3.12] gh-121039: add Floats/ComplexesAreIdenticalMixin to test.support.testcase (GH-121071)
(cherry picked from commit 8ef8354)

Co-authored-by: Sergey B Kirpichev <[email protected]>

Yhg1s pushed a commit that referenced this pull request

Sep 30, 2024


          [3.13] gh-121039: add Floats/ComplexesAreIdenticalMixin to test.suppo…

62e54dd

…rt.testcase (GH-121071) (#123840)

* [3.13] gh-121039: add Floats/ComplexesAreIdenticalMixin to test.support.testcase (GH-121071)
(cherry picked from commit 8ef8354)

Co-authored-by: Sergey B Kirpichev <[email protected]>

* +1

serhiy-storchaka removed their assignment

Jul 15, 2026

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

sobolevn

sobolevn approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

skirpichev commented Jun 27, 2024 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

sobolevn commented Jun 27, 2024

Uh oh!

skirpichev commented Jun 27, 2024

Uh oh!

skirpichev commented Jul 10, 2024

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka commented Sep 8, 2024

Uh oh!

skirpichev commented Sep 8, 2024

Uh oh!

miss-islington-app Bot commented Sep 8, 2024

Uh oh!

miss-islington-app Bot commented Sep 8, 2024

Uh oh!

miss-islington-app Bot commented Sep 8, 2024

Uh oh!

miss-islington-app Bot commented Sep 8, 2024

Uh oh!

skirpichev commented Sep 8, 2024

Uh oh!

bedevere-app Bot commented Sep 8, 2024

Uh oh!

bedevere-app Bot commented Sep 8, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

skirpichev commented Jun 27, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.