GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121082: Fix build failure when the developer use `--enable-pystats` arguments in configuration command after #118450 by Zheaoli · Pull Request #121083 · python/cpython

Conversation

@Zheaoli

@Zheaoli Zheaoli commented Jun 27, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix: #121082

  • Issue: CPython build failed with --enable-pystats after #118450 #121082

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Zheaoli
Fix build failure when the developer use --enable-pystats arguments…
67a8f6f 
… in configuration command after python#118450

Signed-off-by: Manjusaka <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Jun 27, 2024
@Zheaoli Zheaoli changed the title Fix build failure when the developer use --enable-pystats arguments in configuration command after #118450 gh121082: Fix build failure when the developer use --enable-pystats arguments in configuration command after #118450 Jun 27, 2024
@Zheaoli Zheaoli changed the title gh121082: Fix build failure when the developer use --enable-pystats arguments in configuration command after #118450 GH-121082: Fix build failure when the developer use --enable-pystats arguments in configuration command after #118450 Jun 27, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 27, 2024
CPython build failed with --enable-pystats after #118450 #121082
Closed
@Zheaoli Zheaoli changed the title GH-121082: Fix build failure when the developer use --enable-pystats arguments in configuration command after #118450 gh-121082: Fix build failure when the developer use --enable-pystats arguments in configuration command after #118450 Jun 27, 2024
Zheaoli added 2 commits June 27, 2024 18:10
@Zheaoli
fix docs lint
8765ccc 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
Fix docs lint error
ac7a385
@Eclips4
Eclips4 requested a review from Fidget-Spinner June 27, 2024 10:15
@Zheaoli
Fix docs lint error
1d408a6
Fidget-Spinner
Fidget-Spinner reviewed Jun 27, 2024
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one minor nit

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/specialize.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner
Fidget-Spinner reviewed Jun 27, 2024
View reviewed changes
Comment thread Python/specialize.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/specialize.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/specialize.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Apply suggestions from code review
febd257
Fidget-Spinner
Fidget-Spinner approved these changes Jun 27, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 27, 2024
@Zheaoli

Zheaoli commented Jun 27, 2024

Copy link
Copy Markdown
Contributor Author

Thanks! Just one minor nit

Thanks for the tips!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Fidget-Spinner merged commit 223c03a into python:main Jun 27, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 27, 2024
@Zheaoli
Zheaoli deleted the manjusaka/gh121082 branch June 27, 2024 11:36
@Fidget-Spinner Fidget-Spinner mentioned this pull request Jun 27, 2024
Thread sanitizer (free-threading) tests fail: test_signal raises RecursionError #121065
Open
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@Zheaoli @Fidget-Spinner @mrahtz
pythongh-121082: Fix build failure when the developer use `--enable-p…
794f146 
…ystats` arguments in configuration command after python#118450 (python#121083)



Signed-off-by: Manjusaka <[email protected]>
Co-authored-by: Ken Jin <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Zheaoli @Fidget-Spinner @estyxx
pythongh-121082: Fix build failure when the developer use `--enable-p…
7aea987 
…ystats` arguments in configuration command after python#118450 (python#121083)



Signed-off-by: Manjusaka <[email protected]>
Co-authored-by: Ken Jin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CPython build failed with --enable-pystats after #118450

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Zheaoli @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.