GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121027: Add a future warning in functools.partial.__get__ by serhiy-storchaka · Pull Request #121086 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 27, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add __get__ to the partial object #121027

📚 Documentation preview 📚: https://cpython-previews--121086.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nineteendo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@serhiy-storchaka
pythongh-121027: Add a future warning in functools.partial.__get__
b057ae6
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 only security fixes label Jun 27, 2024
@serhiy-storchaka
serhiy-storchaka requested review from Yhg1s and rhettinger June 27, 2024 11:05
@bedevere-app bedevere-app Bot mentioned this pull request Jun 27, 2024
Add __get__ to the partial object #121027
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 27, 2024
Yhg1s
Yhg1s approved these changes Jun 27, 2024
View reviewed changes

@Yhg1s Yhg1s left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really that happy about getting this into 3.13 at this stage, but whatever, it's only a FutureWarning on something that's a bad idea anyway (by which I mean using functools.partial in the first place, as well as using it as a class attribute.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 27, 2024
@serhiy-storchaka @Yhg1s
Update Doc/whatsnew/3.13.rst
fa4be09 
Co-authored-by: T. Wouters <[email protected]>
@Yhg1s
Yhg1s enabled auto-merge (squash) June 27, 2024 11:41
@nineteendo nineteendo mentioned this pull request Jun 27, 2024
gh-121027: Make the functools.partial object a method descriptor #121089
Merged
@Yhg1s
Yhg1s merged commit db96edd into python:main Jun 27, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 27, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 27, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR, and @Yhg1s for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2024
@serhiy-storchaka @miss-islington
pythongh-121027: Add a future warning in functools.partial.__get__ (p…
872bb29 
…ythonGH-121086)

(cherry picked from commit db96edd)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 27, 2024

Copy link
Copy Markdown

GH-121092 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 27, 2024
Yhg1s pushed a commit that referenced this pull request Jun 27, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-121027: Add a future warning in functools.partial.__get__ (G…
49e5740 
…H-121086) (#121092)

gh-121027: Add a future warning in functools.partial.__get__ (GH-121086)
(cherry picked from commit db96edd)

Co-authored-by: Serhiy Storchaka <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@serhiy-storchaka @mrahtz
pythongh-121027: Add a future warning in functools.partial.__get__ (p…
da39581 
…ython#121086)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@serhiy-storchaka @estyxx
pythongh-121027: Add a future warning in functools.partial.__get__ (p…
86a23c9 
…ython#121086)
@mgorny mgorny mentioned this pull request Jul 21, 2024
3.13.0b3: undocumented change in inspect.isroutine() for functools.partial #122087
Closed
@serhiy-storchaka
serhiy-storchaka deleted the partial-get-future-warning branch July 1, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.