GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-121018: Fix more cases of exiting in argparse when exit_on_error=False (GH-121056) by serhiy-storchaka · Pull Request #121128 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 28, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • parse_intermixed_args() now raises ArgumentError instead of calling error() if exit_on_error is false.
  • Internal code now always raises ArgumentError instead of calling error(). It is then caught at the higher level and error() is called if exit_on_error is true. (cherry picked from commit 81a654a)
  • Issue: argparse.ArgumentParser.parses_args does not honor exit_on_error=False when given unrecognized arguments #121018

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka
[3.13] pythongh-121018: Fix more cases of exiting in argparse when ex…
4921ac8
…it_on_error=False (pythonGH-121056)

* parse_intermixed_args() now raises ArgumentError instead of calling
  error() if exit_on_error is false.
* Internal code now always raises ArgumentError instead of calling
  error(). It is then caught at the higher level and error() is called if
  exit_on_error is true.
(cherry picked from commit 81a654a)

Co-authored-by: Serhiy Storchaka <[email protected]>
This was referenced Jun 28, 2024
argparse.ArgumentParser.parses_args does not honor exit_on_error=False when given unrecognized arguments #121018
Closed
gh-121018: Fix more cases of exiting in argparse when exit_on_error=False #121056
Merged
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 28, 2024
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) June 28, 2024 14:34
@serhiy-storchaka
Update 2024-06-26-03-04-24.gh-issue-121018.clVSc4.rst
89a39b6
@serhiy-storchaka
serhiy-storchaka merged commit 99de20d into python:3.13 Jun 28, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 28, 2024
@serhiy-storchaka
serhiy-storchaka deleted the backport-81a654a-3.13 branch October 21, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.