GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121018: Fix more cases of exiting in argparse when exit_on_error=False by serhiy-storchaka · Pull Request #121056 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 26, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • parse_intermixed_args() now raises ArgumentError instead of calling error() if exit_on_error is false.
  • Internal code now always raises ArgumentError instead of calling error(). It is then caught at higher level and error() is called if exit_on_error is true.
  • Issue: argparse.ArgumentParser.parses_args does not honor exit_on_error=False when given unrecognized arguments #121018

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lrq3000 reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@serhiy-storchaka
pythongh-121018: Fix more cases of exiting in argparse when exit_on_e…
fdcadd5 
…rror=False

* parse_intermixed_args() now raises ArgumentError instead of calling
  error() if exit_on_error is false.
* Internal code now always raises ArgumentError instead of calling
  error(). It is then caught at higher level and error() is called if
  exit_on_error is true.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jun 26, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 26, 2024
argparse.ArgumentParser.parses_args does not honor exit_on_error=False when given unrecognized arguments #121018
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 26, 2024
This was referenced Jun 26, 2024
argparse exits on error even when exit_on_error=False #103498
Closed
Argparse.parse_args exits on unrecognized option with exit_on_error=False #85427
Closed
@serhiy-storchaka
serhiy-storchaka merged commit 81a654a into python:main Jun 28, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 28, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 28, 2024
@serhiy-storchaka
serhiy-storchaka deleted the argparse-exit_on_error branch June 28, 2024 14:22
@miss-islington-app

miss-islington-app Bot commented Jun 28, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 81a654a3425eaa05a51342509089533c1f623f1b 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned serhiy-storchaka Jun 28, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 28, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 81a654a3425eaa05a51342509089533c1f623f1b 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 28, 2024
@serhiy-storchaka
[3.13] pythongh-121018: Fix more cases of exiting in argparse when ex…
4921ac8 
…it_on_error=False (pythonGH-121056)

* parse_intermixed_args() now raises ArgumentError instead of calling
  error() if exit_on_error is false.
* Internal code now always raises ArgumentError instead of calling
  error(). It is then caught at the higher level and error() is called if
  exit_on_error is true.
(cherry picked from commit 81a654a)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 28, 2024

Copy link
Copy Markdown

GH-121128 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 28, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 28, 2024
@serhiy-storchaka
[3.12] pythongh-121018: Fix more cases of exiting in argparse when ex…
8ad9e73 
…it_on_error=False (pythonGH-121056)

* parse_intermixed_args() now raises ArgumentError instead of calling
  error() if exit_on_error is false.
* Internal code now always raises ArgumentError instead of calling
  error(). It is then caught at the higher level and error() is called if
  exit_on_error is true.
(cherry picked from commit 81a654a)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 28, 2024

Copy link
Copy Markdown

GH-121129 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jun 28, 2024
serhiy-storchaka added a commit that referenced this pull request Jun 28, 2024
@serhiy-storchaka
[3.12] gh-121018: Fix more cases of exiting in argparse when exit_on_…
8ea6cc1 
…error=False (GH-121056) (GH-121129)

* parse_intermixed_args() now raises ArgumentError instead of calling
  error() if exit_on_error is false.
* Internal code now always raises ArgumentError instead of calling
  error(). It is then caught at the higher level and error() is called if
  exit_on_error is true.
(cherry picked from commit 81a654a)
serhiy-storchaka added a commit that referenced this pull request Jun 28, 2024
@serhiy-storchaka
[3.13] gh-121018: Fix more cases of exiting in argparse when exit_on_…
99de20d 
…error=False (GH-121056) (GH-121128)

* parse_intermixed_args() now raises ArgumentError instead of calling
  error() if exit_on_error is false.
* Internal code now always raises ArgumentError instead of calling
  error(). It is then caught at the higher level and error() is called if
  exit_on_error is true.
(cherry picked from commit 81a654a)
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@serhiy-storchaka @mrahtz
pythongh-121018: Fix more cases of exiting in argparse when exit_on_e…
c5dd349 
…rror=False (pythonGH-121056)

* parse_intermixed_args() now raises ArgumentError instead of calling
  error() if exit_on_error is false.
* Internal code now always raises ArgumentError instead of calling
  error(). It is then caught at the higher level and error() is called if
  exit_on_error is true.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@serhiy-storchaka @estyxx
pythongh-121018: Fix more cases of exiting in argparse when exit_on_e…
e8a6780 
…rror=False (pythonGH-121056)

* parse_intermixed_args() now raises ArgumentError instead of calling
  error() if exit_on_error is false.
* Internal code now always raises ArgumentError instead of calling
  error(). It is then caught at the higher level and error() is called if
  exit_on_error is true.
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.