GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-120522: Add a `--with-app-store-compliance` configure option to patch out problematic code (GH-120984) by miss-islington · Pull Request #121173 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 30, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

  • Add --app-store-compliance configuration option.

  • Added blurb.

  • Correct tab-vs-spaces formatting issue.

  • Correct source file name in docs.

Co-authored-by: Nice Zombies [email protected]

  • Correct source code reference in Mac docs

Co-authored-by: Nice Zombies [email protected]

  • Only apply the patch forward, and ensure the working directory is correct.

  • Make patching reslient to multiple builds.

  • Documentation fixes found during review

Co-authored-by: Alyssa Coghlan [email protected]

  • Documentation and configure.ac syntax improvements

Co-authored-by: Erlend E. Aasland [email protected]

  • Regenerate configure script.

  • Silence the patch echo output.

(cherry picked from commit 48cd104)

Co-authored-by: Russell Keith-Magee [email protected]
Co-authored-by: Nice Zombies [email protected]
Co-authored-by: Alyssa Coghlan [email protected]
Co-authored-by: Erlend E. Aasland [email protected]

  • Issue: Python 3.12 change results in Apple App Store rejection #120522

📚 Documentation preview 📚: https://cpython-previews--121173.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@freakboy3742 @nineteendo
@ncoghlan @erlend-aasland @miss-islington
pythongh-120522: Add a --with-app-store-compliance configure option…
0b733c5 
… to patch out problematic code (pythonGH-120984)

* Add --app-store-compliance configuration option.

* Added blurb.

* Correct tab-vs-spaces formatting issue.

* Correct source file name in docs.

Co-authored-by: Nice Zombies <[email protected]>

* Correct source code reference in Mac docs

Co-authored-by: Nice Zombies <[email protected]>

* Only apply the patch forward, and ensure the working directory is correct.

* Make patching reslient to multiple builds.

* Documentation fixes found during review

Co-authored-by: Alyssa Coghlan <[email protected]>

* Documentation and configure.ac syntax improvements

Co-authored-by: Erlend E. Aasland <[email protected]>

* Regenerate configure script.

* Silence the patch echo output.

---------

(cherry picked from commit 48cd104)

Co-authored-by: Russell Keith-Magee <[email protected]>
Co-authored-by: Nice Zombies <[email protected]>
Co-authored-by: Alyssa Coghlan <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
@miss-islington
miss-islington requested review from a team, corona10, erlend-aasland and freakboy3742 as code owners June 30, 2024 00:34
This was referenced Jun 30, 2024
Python 3.12 change results in Apple App Store rejection #120522
Closed
gh-120522: Add a --with-app-store-compliance configure option to patch out problematic code #120984
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jun 30, 2024
freakboy3742
freakboy3742 approved these changes Jun 30, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 30, 2024
@freakboy3742
freakboy3742 merged commit 0dfb437 into python:3.13 Jun 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 30, 2024
@freakboy3742 freakboy3742 mentioned this pull request Jul 16, 2024
gh-120522: Apply App Store compliance patch to installed products, not source #121830
Closed
ned-deily added a commit to ned-deily/cpython that referenced this pull request Jul 16, 2024
@ned-deily
[3.13] pythongh-120522: Revert "Add a --with-app-store-compliance c…
f28a5e4 
…onfigure option to patch out problematic code" (pythonGH-121173)

This reverts commit 0dfb437 prior
to the release of 3.13.0b4 to allow for additional review time.
@miss-islington
miss-islington deleted the backport-48cd104-3.13 branch January 2, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.