GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121196: Document `dict.fromkeys` params as pos-only by sobolevn · Pull Request #121197 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Jul 1, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Please, consider that some subtypes of dict change the signature back to pos-or-keyword args.
But, since this is only about dict, I guess we can be very specific about it.

Do we backport this change?

  • Issue: dict.fromkeys must mark its parameters as pos-only #121196

📚 Documentation preview 📚: https://cpython-previews--121197.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-121196: Document dict.fromkeys params as pos-only
ce8f364
@sobolevn
sobolevn requested a review from hugovk July 1, 2024 07:16
@bedevere-app bedevere-app Bot mentioned this pull request Jul 1, 2024
dict.fromkeys must mark its parameters as pos-only #121196
Closed
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting core review labels Jul 1, 2024
@terryjreedy terryjreedy added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 1, 2024
@terryjreedy

terryjreedy commented Jul 1, 2024

Copy link
Copy Markdown
Member

Doc patches usually get backported when applicable, especially if they automerge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jul 1, 2024

Copy link
Copy Markdown
Contributor

I would prefer to update the whole dict docs page, not only one method.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Jul 1, 2024

Copy link
Copy Markdown
Member Author

@erlend-aasland I think that it is complicated. .get is the most complex one. Since Mapping and dict are not the same here.

So, I would prefer to have a smaller scope for this change.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Jul 1, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 1, 2024
@sobolevn
sobolevn merged commit 1dc9a4f into python:main Jul 1, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 1, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 1, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2024
@sobolevn @miss-islington
pythongh-121196: Document dict.fromkeys params as pos-only (pythonG…
bda3d4c 
…H-121197)

(cherry picked from commit 1dc9a4f)

Co-authored-by: sobolevn <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2024
@sobolevn @miss-islington
pythongh-121196: Document dict.fromkeys params as pos-only (pythonG…
7557dc1 
…H-121197)

(cherry picked from commit 1dc9a4f)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 1, 2024

Copy link
Copy Markdown

GH-121242 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Jul 1, 2024

Copy link
Copy Markdown
Member Author

Thanks everyone!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 1, 2024
@sobolevn sobolevn added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jul 1, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 1, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2024
@sobolevn @miss-islington
pythongh-121196: Document dict.fromkeys params as pos-only (pythonG…
c1050de 
…H-121197)

(cherry picked from commit 1dc9a4f)

Co-authored-by: sobolevn <[email protected]>
sobolevn added a commit that referenced this pull request Jul 1, 2024
@miss-islington @sobolevn
[3.12] gh-121196: Document dict.fromkeys params as pos-only (GH-121197
e5a19b9 
) (#121243)

gh-121196: Document `dict.fromkeys` params as pos-only (GH-121197)
(cherry picked from commit 1dc9a4f)

Co-authored-by: sobolevn <[email protected]>
sobolevn added a commit that referenced this pull request Jul 1, 2024
@miss-islington @sobolevn
[3.13] gh-121196: Document dict.fromkeys params as pos-only (GH-121197
78c7732 
) (#121242)

gh-121196: Document `dict.fromkeys` params as pos-only (GH-121197)
(cherry picked from commit 1dc9a4f)

Co-authored-by: sobolevn <[email protected]>
Akasurde pushed a commit to Akasurde/cpython that referenced this pull request Jul 3, 2024
@sobolevn @Akasurde
pythongh-121196: Document dict.fromkeys params as pos-only (python#…
ab15da2 
…121197)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
pythongh-121196: Document dict.fromkeys params as pos-only (python#…
e7b5a6d 
…121197)
@ezio-melotti ezio-melotti mentioned this pull request Jul 20, 2024
Define and document a procedure for following up on reviews python/devguide#1359
Open
@hugovk hugovk removed the needs backport to 3.12 only security fixes label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @terryjreedy @erlend-aasland @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.