GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-121188: Sanitize invalid XML characters in regrtest (GH-121195) by miss-islington · Pull Request #121205 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 1, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
(cherry picked from commit af8c3d7)

Co-authored-by: Victor Stinner [email protected]

  • Issue: Test suite interrupted by xml.etree.ElementTree.ParseError: not well-formed (invalid token) #121188

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @miss-islington
pythongh-121188: Sanitize invalid XML characters in regrtest (pythonG…
c1c3fbe 
…H-121195)

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
(cherry picked from commit af8c3d7)

Co-authored-by: Victor Stinner <[email protected]>
This was referenced Jul 1, 2024
Test suite interrupted by xml.etree.ElementTree.ParseError: not well-formed (invalid token) #121188
Closed
gh-121188: Escape invalid XML characters in regrtest #121195
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jul 1, 2024
@vstinner
vstinner enabled auto-merge (squash) July 1, 2024 08:38
@vstinner
vstinner merged commit b80edaf into python:3.12 Jul 1, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jul 1, 2024
@miss-islington
miss-islington deleted the backport-af8c3d7-3.12 branch January 2, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.