GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121188: Escape invalid XML characters in regrtest by vstinner · Pull Request #121195 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jul 1, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

When creating the JUnit XML file, regrtest now escapes characters which are invalid in XML, such as the chr(27) control character used in ANSI escape sequences.

  • Issue: Test suite interrupted by xml.etree.ElementTree.ParseError: not well-formed (invalid token) #121188

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-121188: Escape invalid XML characters in regrtest
9753167 
When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
@bedevere-app bedevere-app Bot mentioned this pull request Jul 1, 2024
Test suite interrupted by xml.etree.ElementTree.ParseError: not well-formed (invalid token) #121188
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 1, 2024
@vstinner vstinner added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes and removed awaiting core review labels Jul 1, 2024
@vstinner
Add more tests
408e224
serhiy-storchaka
serhiy-storchaka reviewed Jul 1, 2024
View reviewed changes
Comment thread Lib/test/libregrtest/utils.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/libregrtest/utils.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/libregrtest/utils.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/libregrtest/utils.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Address Serhiy's review
b2ffbe4
@vstinner

vstinner commented Jul 1, 2024

Copy link
Copy Markdown
Member Author

@serhiy-storchaka: I addressed your review (I applied your suggestions). Please review the updated PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Jul 1, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting merge label Jul 1, 2024
@vstinner
vstinner enabled auto-merge (squash) July 1, 2024 08:18
@vstinner

vstinner commented Jul 1, 2024

Copy link
Copy Markdown
Member Author

!buildbot s390x SLES PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 1, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit b2ffbe4 🤖

The command will test the builders whose names match following regular expression: s390x SLES PR

The builders matched are:

  • s390x SLES PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit af8c3d7 into python:main Jul 1, 2024
@vstinner
vstinner deleted the regrtest_xml branch July 1, 2024 08:30
@miss-islington-app

miss-islington-app Bot commented Jul 1, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 1, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2024
@vstinner @miss-islington
pythongh-121188: Sanitize invalid XML characters in regrtest (pythonG…
09beeed 
…H-121195)

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
(cherry picked from commit af8c3d7)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 1, 2024

Copy link
Copy Markdown

GH-121204 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2024
@vstinner @miss-islington
pythongh-121188: Sanitize invalid XML characters in regrtest (pythonG…
c1c3fbe 
…H-121195)

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
(cherry picked from commit af8c3d7)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 1, 2024
@bedevere-app

bedevere-app Bot commented Jul 1, 2024

Copy link
Copy Markdown

GH-121205 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 1, 2024
@vstinner

vstinner commented Jul 1, 2024

Copy link
Copy Markdown
Member Author

Merged, thanks your help @serhiy-storchaka!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit that referenced this pull request Jul 1, 2024
@miss-islington @vstinner
[3.12] gh-121188: Sanitize invalid XML characters in regrtest (GH-121195
b80edaf 
) (#121205)

gh-121188: Sanitize invalid XML characters in regrtest (GH-121195)

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
(cherry picked from commit af8c3d7)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this pull request Jul 1, 2024
@miss-islington @vstinner
[3.13] gh-121188: Sanitize invalid XML characters in regrtest (GH-121195
1f2f9c4 
) (#121204)

gh-121188: Sanitize invalid XML characters in regrtest (GH-121195)

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
(cherry picked from commit af8c3d7)

Co-authored-by: Victor Stinner <[email protected]>
Akasurde pushed a commit to Akasurde/cpython that referenced this pull request Jul 3, 2024
@vstinner @Akasurde
pythongh-121188: Sanitize invalid XML characters in regrtest (python#…
a95fdf1 
…121195)

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-121188: Sanitize invalid XML characters in regrtest (python#…
45d3d42 
…121195)

When creating the JUnit XML file, regrtest now escapes characters
which are invalid in XML, such as the chr(27) control character used
in ANSI escape sequences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @bedevere-bot @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.