GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117139: Add _PyTuple_FromStackRefSteal and use it by colesbury · Pull Request #121244 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Jul 1, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This avoids the extra conversion from stack refs to PyObjects.

  • Issue: Set up tagged pointers in the evaluation stack #117139

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-117139: Add _PyTuple_FromStackRefSteal and use it
93feb92 
Avoids the extra conversion from stack refs to PyObjects.
@colesbury colesbury added skip news topic-free-threading labels Jul 1, 2024
@colesbury
colesbury requested a review from Fidget-Spinner July 1, 2024 20:57
@colesbury
colesbury requested a review from markshannon as a code owner July 1, 2024 20:57
@bedevere-app bedevere-app Bot mentioned this pull request Jul 1, 2024
Set up tagged pointers in the evaluation stack #117139
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 1, 2024
@colesbury

colesbury commented Jul 1, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot nogil refleak
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 1, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 93feb92 🤖

The command will test the builders whose names match following regular expression: nogil refleak

The builders matched are:

  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • AMD64 Fedora Rawhide NoGIL refleaks PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
Use PyAPI_FUNC for jit
c1d5deb
@Fidget-Spinner

Fidget-Spinner commented Jul 2, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This fixes the refleak on my branch as well right? I assume so since we no longer hide conversions, and it looks right here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner
Fidget-Spinner approved these changes Jul 2, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 2, 2024
@colesbury

colesbury commented Jul 2, 2024

Copy link
Copy Markdown
Contributor Author

Yes, it should fix the leak as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury merged commit 8e8d202 into python:main Jul 2, 2024
@colesbury
colesbury deleted the gh-117139-tuple branch July 2, 2024 16:30
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 2, 2024
Akasurde pushed a commit to Akasurde/cpython that referenced this pull request Jul 3, 2024
@colesbury @Akasurde
pythongh-117139: Add _PyTuple_FromStackRefSteal and use it (python#12…
d19d6db 
…1244)

Avoids the extra conversion from stack refs to PyObjects.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@colesbury @estyxx
pythongh-117139: Add _PyTuple_FromStackRefSteal and use it (python#12…
91fb626 
…1244)

Avoids the extra conversion from stack refs to PyObjects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@colesbury @bedevere-bot @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.