GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121035: Improve logging flow diagram for dark/light modes. by vsajip · Pull Request #121254 · python/cpython

Conversation

@vsajip

@vsajip vsajip commented Jul 2, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Include lastResort in logging HOWTO flow chart #121035

📚 Documentation preview 📚: https://cpython-previews--121254.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vsajip
pythongh-121035: Improve logging flow diagram with respect to dark/li…
1a438bb 
…ght modes.
@vsajip vsajip added docs Documentation in the Doc dir skip news labels Jul 2, 2024
@vsajip vsajip self-assigned this Jul 2, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 2, 2024
Include lastResort in logging HOWTO flow chart #121035
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 2, 2024
@vsajip
vsajip merged commit bfe0e4d into python:main Jul 2, 2024
@vsajip
vsajip deleted the logging-flow-diagram branch July 2, 2024 08:13
@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 2, 2024
@vsajip vsajip added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 2, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 2, 2024

Copy link
Copy Markdown

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 2, 2024

Copy link
Copy Markdown

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsajip vsajip added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes and removed needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 2, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 2, 2024

Copy link
Copy Markdown

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 2, 2024

Copy link
Copy Markdown

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsajip vsajip mentioned this pull request Jul 2, 2024
gh-121035: Update logging flow chart to include lastResort #121036
Merged
@bessman

bessman commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

This does not work for me with the combination of browser dark mode + light theme selected via drop down. The diagram rendered as white on white in this case.

It does work for browser light mode + dark theme selected via drop down, however.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsajip

vsajip commented Jul 2, 2024

Copy link
Copy Markdown
Member Author

OK, thanks for the feedback. I'll look at that case.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsajip

vsajip commented Jul 2, 2024

Copy link
Copy Markdown
Member Author

I have a new PR, #121265 - it should fix the problem. Please feel free to try it out.

I created some screenshots: In the following, names are X-Y where the X is the browser (Firefox) mode and Y is the theme selector value.

auto-auto:
auto-auto

auto-light:
auto-light

auto-dark:
auto-dark

light-auto:
light-auto

light-light:
light-light

light-dark:
light-dark

dark-auto:
dark-auto

dark-light:
dark-light

dark-dark:
dark-dark
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Akasurde pushed a commit to Akasurde/cpython that referenced this pull request Jul 3, 2024
@vsajip @Akasurde
pythongh-121035: Improve logging flow diagram for dark/light modes. (p…
0972089 
…ythonGH-121254)
vsajip added a commit to vsajip/cpython that referenced this pull request Jul 3, 2024
@vsajip
[3.12] pythongh-121035: Improve logging flow diagram for dark/light m…
bd43fcf 
…odes. (pythonGH-121254)

(cherry picked from commit bfe0e4d)

Co-authored-by: Vinay Sajip <[email protected]>
@vsajip vsajip mentioned this pull request Jul 3, 2024
[3.12] gh-121035: Improve logging flow diagram for dark/light modes. … #121316
Merged
@bedevere-app

bedevere-app Bot commented Jul 3, 2024

Copy link
Copy Markdown

GH-121316 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 3, 2024
vsajip added a commit to vsajip/cpython that referenced this pull request Jul 3, 2024
@vsajip
[3.13] pythongh-121035: Improve logging flow diagram for dark/light m…
845d861 
…odes. (pythonGH-121254)

(cherry picked from commit bfe0e4d)

Co-authored-by: Vinay Sajip <[email protected]>
@vsajip vsajip mentioned this pull request Jul 3, 2024
[3.13] gh-121035: Improve logging flow diagram for dark/light modes. … #121317
Merged
@bedevere-app

bedevere-app Bot commented Jul 3, 2024

Copy link
Copy Markdown

GH-121317 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 3, 2024
vsajip added a commit that referenced this pull request Jul 3, 2024
@vsajip
[3.12] gh-121035: Improve logging flow diagram for dark/light modes. (G…
c3f393c 
…H-121254) (GH-121316)

(cherry picked from commit bfe0e4d)
vsajip added a commit that referenced this pull request Jul 3, 2024
@vsajip
[3.13] gh-121035: Improve logging flow diagram for dark/light modes. (G…
b62605d 
…H-121254) (GH-121317)

(cherry picked from commit bfe0e4d)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vsajip @estyxx
pythongh-121035: Improve logging flow diagram for dark/light modes. (p…
aa70c04 
…ythonGH-121254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vsajip vsajip

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vsajip @bessman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.