GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112136: Restore removed _PyArg_Parser by vstinner · Pull Request #121262 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jul 2, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Restore removed private _PyArg_Parser structure and private _PyArg_ParseTupleAndKeywordsFast() function.

Recreate Include/cpython/modsupport.h header file.

  • Issue: [C API] Removed private _PyArg_Parser API has no replacement in Python 3.13 #112136

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner requested review from a team, ericsnowcurrently and erlend-aasland as code owners July 2, 2024 11:22
@bedevere-app bedevere-app Bot mentioned this pull request Jul 2, 2024
[C API] Removed private _PyArg_Parser API has no replacement in Python 3.13 #112136
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 2, 2024
@vstinner
pythongh-112136: Restore removed _PyArg_Parser
6835e33 
Restore the private _PyArg_Parser structure and the private
_PyArg_ParseTupleAndKeywordsFast() function, previously removed
in Python 3.13 alpha 1.

Recreate Include/cpython/modsupport.h header file.
@vstinner
vstinner force-pushed the revert_arg_parser branch from fb17fb2 to 6835e33 Compare July 2, 2024 11:24
@vstinner

vstinner commented Jul 3, 2024

Copy link
Copy Markdown
Member Author

cc @AdamWill
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit f8373db into python:main Jul 3, 2024
@vstinner
vstinner deleted the revert_arg_parser branch July 3, 2024 16:37
@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 3, 2024
@edgarrmondragon

edgarrmondragon commented Jul 3, 2024

Copy link
Copy Markdown
Contributor

Should this be backported to 3.13?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the needs backport to 3.13 only security fixes label Jul 3, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 3, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2024
@vstinner @miss-islington
pythongh-112136: Restore removed _PyArg_Parser (pythonGH-121262)
795f565 
Restore the private _PyArg_Parser structure and the private
_PyArg_ParseTupleAndKeywordsFast() function, previously removed
in Python 3.13 alpha 1.

Recreate Include/cpython/modsupport.h header file.
(cherry picked from commit f8373db)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 3, 2024

Copy link
Copy Markdown

GH-121344 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 3, 2024
@vstinner

vstinner commented Jul 3, 2024

Copy link
Copy Markdown
Member Author

Should this be backported to 3.13?

Oh right, I forgot that.
edgarrmondragon reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit that referenced this pull request Jul 3, 2024
@miss-islington @vstinner
[3.13] gh-112136: Restore removed _PyArg_Parser (GH-121262) (#121344)
3d4e533 
gh-112136: Restore removed _PyArg_Parser (GH-121262)

Restore the private _PyArg_Parser structure and the private
_PyArg_ParseTupleAndKeywordsFast() function, previously removed
in Python 3.13 alpha 1.

Recreate Include/cpython/modsupport.h header file.
(cherry picked from commit f8373db)

Co-authored-by: Victor Stinner <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-112136: Restore removed _PyArg_Parser (python#121262)
dc38bc8 
Restore the private _PyArg_Parser structure and the private
_PyArg_ParseTupleAndKeywordsFast() function, previously removed
in Python 3.13 alpha 1.

Recreate Include/cpython/modsupport.h header file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @edgarrmondragon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.