GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121160: Note that readline libraries using different history formats. by encukou · Pull Request #121327 · python/cpython

Conversation

@encukou

@encukou encukou commented Jul 3, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is not something we can do too much about, without help from the underlying libraries.

The file formats seem to be treated as implementation details, hidden behind API calls.

  • Issue: readline.set_history_length corrupts history files when used in a libedit build #121160

📚 Documentation preview 📚: https://cpython-previews--121327.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
pythongh-121160: Note that readline libraries using different history…
258d375 
… formats.

This is not something we can do too much about, without help from the
underlying libraries.
@encukou encukou added the docs Documentation in the Doc dir label Jul 3, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 3, 2024
readline.set_history_length corrupts history files when used in a libedit build #121160
Closed
@bedevere-app bedevere-app Bot added skip news awaiting core review labels Jul 3, 2024
@encukou

encukou commented Jul 4, 2024

Copy link
Copy Markdown
Member Author

@Yhg1s, you're the readline expert. Does this look good?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Jul 19, 2024

Copy link
Copy Markdown
Member Author

I'll merge next week.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s

Yhg1s commented Jul 19, 2024

Copy link
Copy Markdown
Member

Eehh, "expert"... But yeah, I think this is the only thing we can do here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s
Yhg1s approved these changes Jul 19, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 19, 2024
@encukou

encukou commented Jul 19, 2024

Copy link
Copy Markdown
Member Author

Thanks!

Expert just means you've signed up for notifications about tricky or controversial changes :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit 709db44 into python:main Jul 19, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 19, 2024
@encukou
encukou deleted the readline-history-doc branch July 19, 2024 13:52
@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 19, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

Sorry, @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 709db44255eb5d73fc22a1341dd0253e71ddfda9 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned encukou Jul 19, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
@encukou @miss-islington
pythongh-121160: Note that readline libraries using different history…
b84ad2a 
… formats. (pythonGH-121327)

This is not something we can do too much about, without help from the
underlying libraries.
(cherry picked from commit 709db44)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

GH-122030 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 19, 2024
@bedevere-app

bedevere-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

GH-122031 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 19, 2024
encukou added a commit to encukou/cpython that referenced this pull request Jul 19, 2024
@encukou
[3.12] pythongh-121160: Note that readline libraries using different …
21ea75a 
…history formats. (pythonGH-121327)

This is not something we can do too much about, without help from the
underlying libraries.
(cherry picked from commit 709db44)

Co-authored-by: Petr Viktorin <[email protected]>
encukou added a commit that referenced this pull request Jul 19, 2024
@miss-islington @encukou
[3.13] gh-121160: Note that readline libraries using different histor…
838025b 
…y formats. (GH-121327) (GH-122030)

This is not something we can do too much about, without help from the
underlying libraries.
(cherry picked from commit 709db44)

Co-authored-by: Petr Viktorin <[email protected]>
encukou added a commit that referenced this pull request Jul 19, 2024
@encukou
[3.12] gh-121160: Note that readline libraries using different histor…
e80497c 
…y formats. (GH-121327) (GH-122031)

This is not something we can do too much about, without help from the
underlying libraries.
(cherry picked from commit 709db44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@encukou encukou

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@encukou @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.