GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106597: Remove unnecessary CFrame offsets by P403n1x87 · Pull Request #121369 · python/cpython

Conversation

@P403n1x87

@P403n1x87 P403n1x87 commented Jul 4, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The PyCFrame structure has been removed in 3.13 therefore its offsets are no longer available to be exported via the debug offsets structure.

  • Issue: Add a collection of offsets to facilitate the work of out-of-process debuggers #106597

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@P403n1x87
pythongh-106597: Remove unnecessary CFrame offsets
2a42f7a 
The PyCFrame structure has been removed in 3.13 therefore its offsets
are no longer available to be exported via the debug offsets structure.
@P403n1x87
P403n1x87 requested a review from ericsnowcurrently as a code owner July 4, 2024 17:01
@bedevere-app bedevere-app Bot mentioned this pull request Jul 4, 2024
Add a collection of offsets to facilitate the work of out-of-process debuggers #106597
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jul 4, 2024
@P403n1x87

P403n1x87 commented Jul 4, 2024

Copy link
Copy Markdown
Contributor Author

@vstinner @pablogsal some cleanup for 3.13 and main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Jul 4, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 4, 2024
@pablogsal pablogsal added skip news needs backport to 3.13 only security fixes and removed awaiting merge labels Jul 4, 2024
pablogsal
pablogsal approved these changes Jul 4, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label Jul 4, 2024
@pablogsal
pablogsal enabled auto-merge (squash) July 4, 2024 17:18
@pablogsal
pablogsal merged commit f5c8d67 into python:main Jul 4, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 4, 2024

Copy link
Copy Markdown

Thanks @P403n1x87 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 4, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 4, 2024
@P403n1x87 @miss-islington
pythongh-106597: Remove unnecessary CFrame offsets (pythonGH-121369)
51b1af3 
(cherry picked from commit f5c8d67)

Co-authored-by: Gabriele N. Tornetta <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 4, 2024

Copy link
Copy Markdown

GH-121370 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 4, 2024
@P403n1x87
P403n1x87 deleted the py-debugoffsets-remove-cframe-offsets branch July 4, 2024 17:31
vstinner pushed a commit that referenced this pull request Jul 4, 2024
@miss-islington @P403n1x87
[3.13] gh-106597: Remove unnecessary CFrame offsets (GH-121369) (#121370
273c993 
)

gh-106597: Remove unnecessary CFrame offsets (GH-121369)
(cherry picked from commit f5c8d67)

Co-authored-by: Gabriele N. Tornetta <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@P403n1x87 @estyxx
pythongh-106597: Remove unnecessary CFrame offsets (python#121369)
dee6975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@P403n1x87 @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.