GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix cache restoration for Hypothesis CI job by webknjaz · Pull Request #121756 · python/cpython

Conversation

@webknjaz

@webknjaz webknjaz commented Jul 14, 2024

Copy link
Copy Markdown
Member

Previously, the CI workflow job running Hypothesis was mistakenly set up to use a cache restoration key prefixed with a leading hyphen [1]. This was done in an attempt to figure out the right format for the actions/cache input argument called restore-keys as the official examples tend to be confusing [2].

This results no cache being found for the Hypothesis database on lookup [3] and the logs contain the following:

Cache not found for input keys: hypothesis-database-9927179210, - hypothesis-database-

The patch corrects that by dropping the unintended characters from the catch-all cache key.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@webknjaz
🧪🚑 Fix cache restoration @ Hypothesis CI job
3446d52 
Previously, the CI workflow job running Hypothesis was mistakenly set
up to use a cache restoration key prefixed with a leading
hyphen [[1]]. This was done in an attempt to figure out the right
format for the `actions/cache` input argument called `restore-keys`
as the official examples tend to be confusing [[2]].

This results no cache being found for the Hypothesis database on
lookup [[3]] and the logs contain the following:

    Cache not found for input keys: hypothesis-database-9927179210, - hypothesis-database-

The patch corrects that by dropping the unintended characters from the
catch-all cache key.

[1]: python@ccbb010#r1677102123
[2]: actions/cache#1173
[3]: https://github.com/python/cpython/actions/runs/9927179210/job/27421821417#step:21:24
@webknjaz
webknjaz requested review from ezio-melotti and hugovk as code owners July 14, 2024 10:33
@bedevere-app bedevere-app Bot added the awaiting review label Jul 14, 2024
@hugovk hugovk added skip issue skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 14, 2024
@webknjaz

webknjaz commented Jul 14, 2024

Copy link
Copy Markdown
Member Author

Here's the proof from this PR's CI run that cache restoration works now, with the patch applied:

Cache Size: ~0 MB (22203 B)
/usr/bin/tar -xf /home/runner/work/_temp/49dc92bc-12d7-4daa-afbd-fb3faf161361/cache.tzst -P -C /home/runner/work/cpython/cpython --use-compress-program unzstd
Cache restored successfully
Cache restored from key: hypothesis-database-9927179210

(https://github.com/python/cpython/actions/runs/9927318541/job/27422127017?pr=121756#step:21:27)
hugovk and Zac-HD reacted with rocket emoji
All reactions
  • 🚀 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Jul 14, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
webknjaz reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 14, 2024
@webknjaz webknjaz mentioned this pull request Jul 14, 2024
gh-86275: improve Hypothesis configuration for CI and local runs #104468
Merged
@hugovk hugovk changed the title 🧪🚑 Fix cache restoration @ Hypothesis CI job Fix cache restoration for Hypothesis CI job Jul 14, 2024
@hugovk
hugovk merged commit 6505bda into python:main Jul 14, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 14, 2024

Copy link
Copy Markdown

Thanks @webknjaz for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 14, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 14, 2024
@webknjaz @miss-islington
Fix cache restoration for Hypothesis CI job (pythonGH-121756)
62fb1d7 
(cherry picked from commit 6505bda)

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 14, 2024

Copy link
Copy Markdown

GH-121759 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 14, 2024
@webknjaz @miss-islington
Fix cache restoration for Hypothesis CI job (pythonGH-121756)
5ec7ca8 
(cherry picked from commit 6505bda)

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 14, 2024
@bedevere-app

bedevere-app Bot commented Jul 14, 2024

Copy link
Copy Markdown

GH-121760 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 14, 2024
hugovk pushed a commit that referenced this pull request Jul 14, 2024
@miss-islington @webknjaz
[3.12] Fix cache restoration for Hypothesis CI job (GH-121756) (#121760)
d870f41 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
hugovk pushed a commit that referenced this pull request Jul 14, 2024
@miss-islington @webknjaz
[3.13] Fix cache restoration for Hypothesis CI job (GH-121756) (#121759)
295b791 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@webknjaz @estyxx
Fix cache restoration for Hypothesis CI job (python#121756)
055c9dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@webknjaz @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.