GeezerVison is showing github.com — GH-105879: Note exec/eval keyword change in What's New by ncoghlan · Pull Request #121831 · python/cpython
Conversation
ncoghlan
commented
Jul 16, 2024
•
edited by github-actions
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 16, 2024
Previously, those flags would sometimes end up having empty string
values which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry.
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 16, 2024
Previously, those flags would sometimes end up having empty string
values which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 16, 2024
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 16, 2024
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 16, 2024
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
|
Rebased to check if #121848 fixes the CI.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
At least the name of the skipped Windows job is still borked.
"Tests / Windows ${{ ((fromJSON(matrix.free-threading) && '(free-threading)') || '') }} (pull_requ"
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
At least the name of the skipped Windows job is still borked.
That's expected. GHA doesn't evaluate skipped matrices, and that would've evaluated to two different names, not one. That's how GHA works. But in general, you don't need to look into those skipped entries as the ones that are of interest to you are prominently marked as red.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@ambv a workaround would be to use a static name: entry and embed the variable bits into the reusable workflow job names one level below. I personally don't really care, but if that annoys you enough, we could go for it.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Though, there might be other limitations with this (some sort of a ${{ '' }} expression, even empty, is usually needed for nicer display in the sidebar when the jobs are actually run).
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@ambv if you still want the job names to be rendered differently — let me know, and I can come up with alternative options.
|
ambv reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
OK, thanks! Let's see how it looks for a while and we'll decide if it's still bothering me later.
|
webknjaz reacted with heart emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|