GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-105879: Note exec/eval keyword change in What's New by ncoghlan · Pull Request #121831 · python/cpython

Conversation

@ncoghlan

@ncoghlan ncoghlan commented Jul 16, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Allow eval and exec to take keyword arguments #105879

📚 Documentation preview 📚: https://cpython-previews--121831.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ncoghlan ncoghlan added docs Documentation in the Doc dir 3.13 only security fixes needs backport to 3.13 only security fixes labels Jul 16, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 16, 2024
Allow eval and exec to take keyword arguments #105879
Closed
@bedevere-app bedevere-app Bot added skip news awaiting core review labels Jul 16, 2024
@ncoghlan
ncoghlan enabled auto-merge (squash) July 16, 2024 03:36
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 16, 2024
@webknjaz
🧪🚑 Fix using check_source flags as bool
1372f5b
Previously, those flags would sometimes end up having empty string
values which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.

This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry.

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment)
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 16, 2024
@webknjaz
🧪🚑 Fix using check_source flags as bool
246cdb7
Previously, those flags would sometimes end up having empty string
values which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.

This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 16, 2024
@webknjaz
🧪🚑 Fix using check_source flags as bool
911e78f
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.

This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
@webknjaz webknjaz mentioned this pull request Jul 16, 2024
CI: Fix using check_source flags as bool #121848
Merged
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 16, 2024
@webknjaz
🧪🚑 Fix using check_source flags as bool
724f8e8
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.

This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 16, 2024
@webknjaz
🧪🚑 Fix using check_source flags as bool
4069c5f
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.

This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
@ncoghlan @hugovk
Note exec/eval keyword change in What's New
101ca8b
@hugovk
hugovk force-pushed the exec-eval-keyword-args-whats-new branch from cb46041 to 101ca8b Compare July 16, 2024 13:00
@hugovk

hugovk commented Jul 16, 2024

Copy link
Copy Markdown
Member

Rebased to check if #121848 fixes the CI.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz

webknjaz commented Jul 16, 2024

Copy link
Copy Markdown
Member

🤞

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv

ambv commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

At least the name of the skipped Windows job is still borked.

"Tests / Windows ${{ ((fromJSON(matrix.free-threading) && '(free-threading)') || '') }} (pull_requ"

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ncoghlan
ncoghlan merged commit d7a099d into python:main Jul 16, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 16, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 16, 2024

Copy link
Copy Markdown

Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2024
@ncoghlan @miss-islington
pythonGH-105879: Note exec/eval keyword change in What's New (pythonG…
8cb9780
…H-121831)

(cherry picked from commit d7a099d)

Co-authored-by: Alyssa Coghlan <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 16, 2024

Copy link
Copy Markdown

GH-121852 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 16, 2024
@webknjaz

webknjaz commented Jul 16, 2024

Copy link
Copy Markdown
Member

At least the name of the skipped Windows job is still borked.

That's expected. GHA doesn't evaluate skipped matrices, and that would've evaluated to two different names, not one. That's how GHA works. But in general, you don't need to look into those skipped entries as the ones that are of interest to you are prominently marked as red.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz

webknjaz commented Jul 16, 2024

Copy link
Copy Markdown
Member

@ambv a workaround would be to use a static name: entry and embed the variable bits into the reusable workflow job names one level below. I personally don't really care, but if that annoys you enough, we could go for it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz

webknjaz commented Jul 16, 2024

Copy link
Copy Markdown
Member

Though, there might be other limitations with this (some sort of a ${{ '' }} expression, even empty, is usually needed for nicer display in the sidebar when the jobs are actually run).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz webknjaz mentioned this pull request Jul 16, 2024
[3.12] CI: Fix using check_source flags as bool (GH-121848) #121855
Merged
ncoghlan added a commit that referenced this pull request Jul 16, 2024
@miss-islington @ncoghlan @ambv
[3.13] GH-105879: Note exec/eval keyword change in What's New (GH-121831
c11d789
) (#121852)

GH-105879: Note exec/eval keyword change in What's New (GH-121831)
(cherry picked from commit d7a099d)

Co-authored-by: Alyssa Coghlan <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@ncoghlan @estyxx
pythonGH-105879: Note exec/eval keyword change in What's New (pythonG…
38c99dc
…H-121831)
@webknjaz

webknjaz commented Jul 24, 2024

Copy link
Copy Markdown
Member

@ambv if you still want the job names to be rendered differently — let me know, and I can come up with alternative options.

ambv reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv

ambv commented Jul 24, 2024

Copy link
Copy Markdown
Contributor

OK, thanks! Let's see how it looks for a while and we'll decide if it's still bothering me later.

webknjaz reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.13 only security fixes docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ncoghlan @hugovk @webknjaz @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.