GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-121970: Make ``DeprecatedRemoved`` a subclass of ``VersionChange`` by AA-Turner · Pull Request #121971 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Jul 18, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The majority of the code was duplicated. A future improvement would be to add some sort of method to VersionChange for determining the version and labels that we could override in this subclass, rather than the somewhat convoluted method here.

Also allow the .. versionremoved:: directive to be used whilst we still support older versions of Sphinx.

A

  • Issue: Improve and reorganise pyspecific #121970

📚 Documentation preview 📚: https://cpython-previews--121971.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
pythonGH-121970: Make DeprecatedRemoved a subclass of ``VersionCh…
06bd386 
…ange``

Also allow the ``.. versionremoved::`` directive to be used whilst we still support older versions of Sphinx.
@AA-Turner
AA-Turner requested a review from encukou July 18, 2024 14:46
@bedevere-app bedevere-app Bot mentioned this pull request Jul 18, 2024
Improve and reorganise pyspecific #121970
Open
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 18, 2024
@AA-Turner AA-Turner added skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 18, 2024
@AA-Turner
Merge branch 'main' into docs/deprecated-removed
934dffc 
# Conflicts:
#	Doc/tools/extensions/pyspecific.py
encukou
encukou reviewed Jul 19, 2024
View reviewed changes
Comment thread Doc/tools/extensions/pyspecific.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Remove versionremoved
c3472d7
encukou
encukou approved these changes Jul 19, 2024
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I trust you that this uses the correct Sphinx APIs :)

I checked that it generates the same output (except timestamps and search index data), at least on my Sphinx v7.2.6

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 19, 2024
@AA-Turner AA-Turner mentioned this pull request Jul 19, 2024
gh-121277: Allow .. versionadded:: next in docs #121278
Merged
@AA-Turner
AA-Turner merged commit 898e90c into python:main Jul 19, 2024
@AA-Turner
AA-Turner deleted the docs/deprecated-removed branch July 19, 2024 10:39
@miss-islington-app

miss-islington-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 19, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
@AA-Turner @miss-islington
pythonGH-121970: Make DeprecatedRemoved a subclass of ``VersionCh…
038c3ba 
…ange`` (pythonGH-121971)

(cherry picked from commit 898e90c)

Co-authored-by: Adam Turner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
@AA-Turner @miss-islington
pythonGH-121970: Make DeprecatedRemoved a subclass of ``VersionCh…
f463c20 
…ange`` (pythonGH-121971)

(cherry picked from commit 898e90c)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

GH-122019 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 19, 2024
@bedevere-app

bedevere-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

GH-122020 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 19, 2024
AA-Turner added a commit that referenced this pull request Jul 19, 2024
@miss-islington @AA-Turner
[3.12] GH-121970: Make DeprecatedRemoved a subclass of ``VersionC…
88618d2 
…hange`` (GH-121971) (#122020)

GH-121970: Make ``DeprecatedRemoved`` a subclass of ``VersionChange`` (GH-121971)
(cherry picked from commit 898e90c)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit that referenced this pull request Jul 19, 2024
@miss-islington @AA-Turner
[3.13] GH-121970: Make DeprecatedRemoved a subclass of ``VersionC…
2c4a60b 
…hange`` (GH-121971) (#122019)

GH-121970: Make ``DeprecatedRemoved`` a subclass of ``VersionChange`` (GH-121971)
(cherry picked from commit 898e90c)

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AA-Turner @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.