GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-121970: Use ``SphinxDirective`` instead of ``Directive`` by AA-Turner · Pull Request #121972 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Jul 18, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Improve and reorganise pyspecific #121970

📚 Documentation preview 📚: https://cpython-previews--121972.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
pythonGH-121970: Use SphinxDirective instead of Directive
40b8b03
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news labels Jul 18, 2024
@AA-Turner
AA-Turner requested review from AlexWaygood and ezio-melotti July 18, 2024 15:11
@bedevere-app bedevere-app Bot mentioned this pull request Jul 18, 2024
Improve and reorganise pyspecific #121970
Open
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 18, 2024
ezio-melotti
ezio-melotti reviewed Jul 18, 2024
View reviewed changes

@ezio-melotti ezio-melotti left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look ok to me, even though I'm not familiar with SphinxDirective.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@AA-Turner AA-Turner added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 19, 2024
@AA-Turner
AA-Turner merged commit ac39151 into python:main Jul 19, 2024
@AA-Turner
AA-Turner deleted the docs/sphinxdirective branch July 19, 2024 07:33
@miss-islington-app

miss-islington-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 19, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
@AA-Turner @miss-islington
pythonGH-121970: Use SphinxDirective instead of Directive (py…
4070c51 
…thonGH-121972)

(cherry picked from commit ac39151)

Co-authored-by: Adam Turner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
@AA-Turner @miss-islington
pythonGH-121970: Use SphinxDirective instead of Directive (py…
c8dc151 
…thonGH-121972)

(cherry picked from commit ac39151)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

GH-122008 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 19, 2024
@bedevere-app

bedevere-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

GH-122009 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 19, 2024
AA-Turner added a commit that referenced this pull request Jul 19, 2024
@miss-islington @AA-Turner
[3.12] GH-121970: Use SphinxDirective instead of Directive (G…
1855784 
…H-121972) (#122009)

GH-121970: Use ``SphinxDirective`` instead of ``Directive`` (GH-121972)
(cherry picked from commit ac39151)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit that referenced this pull request Jul 19, 2024
@miss-islington @AA-Turner
[3.13] GH-121970: Use SphinxDirective instead of Directive (G…
711c328 
…H-121972) (#122008)

GH-121970: Use ``SphinxDirective`` instead of ``Directive`` (GH-121972)
(cherry picked from commit ac39151)

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti ezio-melotti left review comments
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AA-Turner @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.