GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-121970: Rewrite the C-API annotations extension by AA-Turner · Pull Request #121985 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Jul 18, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I've tested the output before and after this commit, entirely equal save for a new link target in c-api/module.html#c.Py_mod_create.create_module and c-api/module.html#c.Py_mod_exec.exec_module (because we switch from patching in :noindex: to using the C Domain's supported :no-index-entry:).

This introduces some new dataclasses, removes the state stored in closures and the Annotated class instance, and does some small cleanups. Notably, stable_abi.dat is changed to storing the role name rather than the object type, which simplifies things a little.

A

📚 Documentation preview 📚: https://cpython-previews--121985.org.readthedocs.build/en/121985/c-api/index.html

  • Issue: Improve and reorganise pyspecific #121970

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AA-Turner added 2 commits July 18, 2024 21:33
@AA-Turner
pythonGH-121970: Rewrite the C-API annotations extension
fd6de2f
@AA-Turner
Update conf.py
af3199c
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip issue labels Jul 18, 2024
@AA-Turner
AA-Turner requested review from encukou and ericsnowcurrently as code owners July 18, 2024 20:42
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 18, 2024
@AA-Turner
fixup! add type hints
04d6372
@AA-Turner AA-Turner added skip news and removed skip issue labels Jul 18, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 18, 2024
Improve and reorganise pyspecific #121970
Open
@AA-Turner AA-Turner added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 19, 2024
AA-Turner added 2 commits July 19, 2024 10:20
@AA-Turner
Underlines
860b007
@AA-Turner
Merge branch 'main' into docs/c-api-annotations
32be4dc
encukou
encukou reviewed Jul 19, 2024
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for refreshing this extension!

Some nitpicks:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread Doc/tools/extensions/c_annotations.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/tools/extensions/c_annotations.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner and others added 2 commits July 19, 2024 10:26
@AA-Turner @encukou
Expand comment
947bcf7 
Co-authored-by: Petr Viktorin <[email protected]>
@AA-Turner
Use standard comments; add a cross-reference in gen_doc_annotations
9b83e81
encukou
encukou approved these changes Jul 19, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 19, 2024
AA-Turner added 2 commits July 19, 2024 12:53
@AA-Turner
Merge branch 'main' into docs/c-api-annotations
f08eb83
@AA-Turner
Run Ruff
9f018dd
@AA-Turner
AA-Turner requested review from AlexWaygood and hugovk as code owners July 19, 2024 11:56
@AA-Turner
AA-Turner enabled auto-merge (squash) July 19, 2024 11:57
@AA-Turner
AA-Turner removed request for AlexWaygood, ericsnowcurrently and hugovk July 19, 2024 11:57
@AA-Turner
AA-Turner merged commit 22c9d9c into python:main Jul 19, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 19, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 22c9d9c1fcc3bb6186524330b169eda6df450f1b 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned AA-Turner Jul 19, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 22c9d9c1fcc3bb6186524330b169eda6df450f1b 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner AA-Turner added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jul 19, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 22c9d9c1fcc3bb6186524330b169eda6df450f1b 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Jul 19, 2024
@AA-Turner @encukou
[3.12] pythonGH-121970: Rewrite the C-API annotations extension (pyth…
ba97898 
…onGH-121985)

(cherry picked from commit 22c9d9c)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

GH-122025 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 19, 2024
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Jul 19, 2024
@AA-Turner @encukou
pythonGH-121970: Rewrite the C-API annotations extension (python#121985)
613f84a 
Co-authored-by: Petr Viktorin <[email protected]>
(cherry picked from commit 22c9d9c)
@bedevere-app

bedevere-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

GH-122027 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 19, 2024
AA-Turner added a commit that referenced this pull request Jul 19, 2024
@AA-Turner @encukou
[3.12] GH-121970: Rewrite the C-API annotations extension (GH-121985) (…
ff98d90 
…#122025)

(cherry picked from commit 22c9d9c)

Co-authored-by: Petr Viktorin <[email protected]>
AA-Turner added a commit that referenced this pull request Jul 19, 2024
@AA-Turner @encukou
[3.13] GH-121970: Rewrite the C-API annotations extension (#121985) (#…
c12f81e 
…122027)

GH-121970: Rewrite the C-API annotations extension (#121985)

Co-authored-by: Petr Viktorin <[email protected]>
(cherry picked from commit 22c9d9c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AA-Turner AA-Turner

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AA-Turner @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.