GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-121970: Improve the glossary preview in HTML search by AA-Turner · Pull Request #121991 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Jul 18, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Pre-populate HTML via the template rather than creating it via JavaScript
  • Extract the JavaScript to its own file
  • Use async/await in JS
  • Fix a potential bug if there are multiple glossary terms for one entry

A

  • Issue: Improve and reorganise pyspecific #121970

📚 Documentation preview 📚: https://cpython-previews--121991.org.readthedocs.build/

Example: https://cpython-previews--121991.org.readthedocs.build/en/121991/search.html?q=qualified+name

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AA-Turner added 4 commits July 18, 2024 22:28
@AA-Turner
Move glossary_search.js to its own file
15a7483
@AA-Turner
Update glossary_search.js
3114261
@AA-Turner
Don't create HTML via JS
006d635
@AA-Turner
Update glossary_search.py
d6fa0be
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news labels Jul 18, 2024
@AA-Turner
AA-Turner requested a review from hugovk July 18, 2024 22:15
@bedevere-app bedevere-app Bot mentioned this pull request Jul 18, 2024
Improve and reorganise pyspecific #121970
Open
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 18, 2024
@AA-Turner
Class -> ID
df586fb
@AA-Turner AA-Turner added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 19, 2024
hugovk
hugovk approved these changes Jul 19, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 19, 2024
@hugovk

hugovk commented Jul 19, 2024

Copy link
Copy Markdown
Member

Merging in main to unstick the CI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
Merge branch 'main' into docs/glossary_search
4ad98c9
@AA-Turner
AA-Turner merged commit adf0b94 into python:main Jul 19, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 19, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
@AA-Turner @miss-islington
pythonGH-121970: Improve the glossary preview in HTML search (pythonG…
3a257d4 
…H-121991)

(cherry picked from commit adf0b94)

Co-authored-by: Adam Turner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
@AA-Turner @miss-islington
pythonGH-121970: Improve the glossary preview in HTML search (pythonG…
c6231cd 
…H-121991)

(cherry picked from commit adf0b94)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

GH-122015 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 19, 2024
@bedevere-app

bedevere-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

GH-122016 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 19, 2024
AA-Turner added a commit that referenced this pull request Jul 19, 2024
@miss-islington @AA-Turner
[3.12] GH-121970: Improve the glossary preview in HTML search (GH-121991
2d4eccf 
) (#122016)

GH-121970: Improve the glossary preview in HTML search (GH-121991)
(cherry picked from commit adf0b94)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit that referenced this pull request Jul 19, 2024
@miss-islington @AA-Turner
[3.13] GH-121970: Improve the glossary preview in HTML search (GH-121991
3b7b3b0 
) (#122015)

GH-121970: Improve the glossary preview in HTML search (GH-121991)
(cherry picked from commit adf0b94)

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AA-Turner @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.